diff options
author | 2017-05-16 00:21:22 +0200 | |
---|---|---|
committer | 2017-05-16 15:24:33 +0200 | |
commit | 211a3ba2303c1df97383c810e17a031106c7271b (patch) | |
tree | 48c862059ebf8ef2515ca599ecdc889902210e4a /src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java | |
parent | 39f328cf392056618d1a3ead4835a138b189a06d (diff) |
Do not access SkylarkProviders anywhere outside of ConfiguredTarget implementation.
A first step towards applying the same memory optimizations we do for
native provider representation to Skylark providers (declared and
legacy).
RELNOTES: None.
PiperOrigin-RevId: 156111749
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java')
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java b/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java index f3e1535916..12fd6b9224 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/AbstractConfiguredTarget.java @@ -89,7 +89,6 @@ public abstract class AbstractConfiguredTarget return "ConfiguredTarget(" + getTarget().getLabel() + ", " + getConfiguration() + ")"; } - @Nullable @Override public <P extends TransitiveInfoProvider> P getProvider(Class<P> provider) { AnalysisUtils.checkProvider(provider); @@ -117,7 +116,7 @@ public abstract class AbstractConfiguredTarget } @Override - public Object getIndex(Object key, Location loc) throws EvalException { + public final Object getIndex(Object key, Location loc) throws EvalException { if (!(key instanceof ClassObjectConstructor)) { throw new EvalException(loc, String.format( "Type Target only supports indexing by object constructors, got %s instead", @@ -149,7 +148,7 @@ public abstract class AbstractConfiguredTarget } @Override - public ImmutableCollection<String> getKeys() { + public final ImmutableCollection<String> getKeys() { ImmutableList.Builder<String> result = ImmutableList.builder(); result.addAll(ImmutableList.of( DATA_RUNFILES_FIELD, @@ -180,7 +179,7 @@ public abstract class AbstractConfiguredTarget @Nullable @Override - public Object get(SkylarkProviderIdentifier id) { + public final Object get(SkylarkProviderIdentifier id) { if (id.isLegacy()) { return get(id.getLegacyId()); } @@ -191,7 +190,7 @@ public abstract class AbstractConfiguredTarget /** Returns a declared provider provided by this target. Only meant to use from Skylark. */ @Nullable @Override - public SkylarkClassObject get(ClassObjectConstructor.Key providerKey) { + public final SkylarkClassObject get(ClassObjectConstructor.Key providerKey) { if (providerKey.equals(DefaultProvider.SKYLARK_CONSTRUCTOR.getKey())) { return getDefaultProvider(); } |