aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2018-07-16 16:29:51 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-07-16 16:31:22 -0700
commitd491bf10f42e213292382c98a1dc439537f00f43 (patch)
tree8971194363c12107cc24594b247dc37f417ab14d /src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java
parenta40f9e30d084a63207affe86fa89fcf4516bb2ba (diff)
Automated rollback of commit eb587075b0d6ffab1cf9e69ede1b7e547905e547.
*** Reason for rollback *** Depot has been fixed. RELNOTES[INC]: If the same artifact is generated by two distinct but identical actions, and a downstream action has both those actions' outputs in its inputs, the artifact will now appear twice in the downstream action's inputs. If this causes problems in Skylark actions, you can use the uniquify=True argument in Args.add_args. PiperOrigin-RevId: 204827477
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java b/src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java
index 703611fd27..fca7d2218c 100644
--- a/src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java
+++ b/src/main/java/com/google/devtools/build/lib/actions/FilesetTraversalParams.java
@@ -26,6 +26,7 @@ import com.google.devtools.build.lib.util.Fingerprint;
import com.google.devtools.build.lib.vfs.PathFragment;
import com.google.devtools.build.lib.vfs.Root;
import com.google.devtools.build.lib.vfs.RootedPath;
+import java.util.Objects;
import javax.annotation.Nullable;
/**
@@ -111,9 +112,7 @@ public interface FilesetTraversalParams {
if (o instanceof FilesetTraversalParams.DirectTraversalRoot) {
FilesetTraversalParams.DirectTraversalRoot that =
(FilesetTraversalParams.DirectTraversalRoot) o;
- // Careful! We must compare the artifact owners, which the default {@link Artifact#equals()}
- // method does not do. See the comments on {@link ArtifactSkyKey} and http://b/73738481.
- return Artifact.equalWithOwner(this.getOutputArtifact(), that.getOutputArtifact())
+ return Objects.equals(this.getOutputArtifact(), that.getOutputArtifact())
&& (this.getRootPart().equals(that.getRootPart()))
&& (this.getRelativePart().equals(that.getRelativePart()));
}