Split ActionMetadata into ActionAnalysisMetadata and ActionExecutionMetadata.

Except in action execution logic (ActionExecutionFunction, SkyframeActionExecutor, etc.), switch Action interface references to either ActionAnalysisMetadata if possible or ActionExecutionMetadata.

--
MOS_MIGRATED_REVID=120723431

1 files changed, 6 insertions, 5 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/actions/ActionGraphVisitor.java b/src/main/java/com/google/devtools/build/lib/actions/ActionGraphVisitor.java
index 7e13e5d2a8..6d335a8f7e 100644
--- a/src/main/java/com/google/devtools/build/lib/actions/ActionGraphVisitor.java
+++ b/src/main/java/com/google/devtools/build/lib/actions/ActionGraphVisitor.java
@@ -17,7 +17,8 @@ package com.google.devtools.build.lib.actions;
  * An abstract visitor for the action graph.  Specializes {@link BipartiteVisitor} for artifacts and
  * actions, and takes care of visiting the complete transitive closure.
  */
-public abstract class ActionGraphVisitor extends BipartiteVisitor<Action, Artifact> {
+public abstract class ActionGraphVisitor extends
+    BipartiteVisitor<ActionAnalysisMetadata, Artifact> {
 
   private final ActionGraph actionGraph;
 
@@ -37,7 +38,7 @@ public abstract class ActionGraphVisitor extends BipartiteVisitor<Action, Artifa
    *
    * @param action
    */
-  protected void visitAction(Action action) {}
+  protected void visitAction(ActionAnalysisMetadata action) {}
 
   /**
    * Whether the given action should be visited. If this returns false, the visitation stops here,
@@ -45,7 +46,7 @@ public abstract class ActionGraphVisitor extends BipartiteVisitor<Action, Artifa
    *
    * @param action  
    */
-  protected boolean shouldVisit(Action action) {
+  protected boolean shouldVisit(ActionAnalysisMetadata action) {
     return true;
   }
 
@@ -67,14 +68,14 @@ public abstract class ActionGraphVisitor extends BipartiteVisitor<Action, Artifa
   }
 
   @Override protected void white(Artifact artifact) {
-    Action action = actionGraph.getGeneratingAction(artifact);
+    ActionAnalysisMetadata action = actionGraph.getGeneratingAction(artifact);
     visitArtifact(artifact);
     if (action != null && shouldVisit(action)) {
       visitBlackNode(action);
     }
   }
 
-  @Override protected void black(Action action) {
+  @Override protected void black(ActionAnalysisMetadata action) {
     visitAction(action);
     for (Artifact input : action.getInputs()) {
       if (shouldVisit(input)) {