Introduce extraPositonals and extraArguments to SkylarkCallable, to have parity with @SkylarkSignature.

This is necessary for several builtin functions that still use @SkylarkSignature, such as string format. These will be migrated in a future CL.

RELNOTES: None.
PiperOrigin-RevId: 192200282

1 files changed, 3 insertions, 5 deletions

diff --git a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java
index fe92bdfe90..60ca32e093 100644
--- a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java
+++ b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java
@@ -42,11 +42,9 @@ public final class SkylarkJavaMethodDoc extends SkylarkMethodDoc {
         : callable.name();
     this.method = method;
     this.callable = callable;
-    ImmutableList.Builder<SkylarkParamDoc> paramsBuilder = ImmutableList.builder();
-    for (Param param : callable.parameters()) {
-      paramsBuilder.add(new SkylarkParamDoc(this, param));
-    }
-    this.params = paramsBuilder.build();
+    this.params =
+        SkylarkDocUtils.determineParams(
+            this, callable.parameters(), callable.extraPositionals(), callable.extraKeywords());
   }
 
   public Method getMethod() {