diff options
| author |  ccalvarin <ccalvarin@google.com> | 2018-04-23 10:40:26 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-04-23 10:41:52 -0700 |
| commit | fec75f46bdc929cc98c23dee7263a972bf7399dc (patch) | |
| tree | e3a91b8d166276e1963af24bea0a137f14a514bf /src/main/cpp | |
| parent | 526d118037f34aea2bbcfff635d078f0b4271fe5 (diff) | |
Declare internal helper functions in option_processor-internal.
It's better for testing, while keeping it clear that these functions should not be used outside of option_processor.cc.
RELNOTES: None.
PiperOrigin-RevId: 193947022
Diffstat (limited to 'src/main/cpp')
| -rw-r--r-- | src/main/cpp/option_processor-internal.h | 7 | ||||
| -rw-r--r-- | src/main/cpp/option_processor.cc | 1 |
2 files changed, 7 insertions, 1 deletions
diff --git a/src/main/cpp/option_processor-internal.h b/src/main/cpp/option_processor-internal.h index 301d2be4fa..8ebfb64c2a 100644 --- a/src/main/cpp/option_processor-internal.h +++ b/src/main/cpp/option_processor-internal.h @@ -17,6 +17,8 @@ #include <algorithm> +#include "src/main/cpp/rc_file.h" +#include "src/main/cpp/util/exit_code.h" #include "src/main/cpp/util/file.h" namespace blaze { @@ -28,6 +30,11 @@ namespace internal { std::vector<std::string> DedupeBlazercPaths( const std::vector<std::string>& paths); +std::string FindRcAlongsideBinary(const std::string& cwd, + const std::string& path_to_binary); + +blaze_exit_code::ExitCode ParseErrorToExitCode(RcFile::ParseError parse_error); + } // namespace internal } // namespace blaze diff --git a/src/main/cpp/option_processor.cc b/src/main/cpp/option_processor.cc index 68237570fe..6fa48fee2a 100644 --- a/src/main/cpp/option_processor.cc +++ b/src/main/cpp/option_processor.cc @@ -167,7 +167,6 @@ blaze_exit_code::ExitCode OptionProcessor::FindUserBlazerc( return blaze_exit_code::SUCCESS; } -// TODO(#4502 related cleanup) This should be an anonymous namespace. namespace internal { vector<string> DedupeBlazercPaths(const vector<string>& paths) { |