diff options
| author |  Loo Rong Jie <loorongjie@gmail.com> | 2018-06-20 06:25:25 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-20 06:27:14 -0700 |
| commit | 3e1e177502133f906d1614e32f2c4af02167e990 (patch) | |
| tree | d94fb20b6fc2625635e051477f3b3d2afba79b85 /src/main/cpp/util/logging.h | |
| parent | 886d01c89fca32e46f5841081eb3288e5b4f313b (diff) | |
[Windows] Fix kOneYear initialization
Fix breakage introduced in #5385 due to incorrect use of `std::move` on local temporary variable after function returns (found by Clang on Windows).
Since `OneYearDelay` function will return the same value and `kOneYear` is only used in one place, remove unused `OneYearDelay` function and move `kOneYear` to `GetFuture` as a `constexpr` constant.
Drive-by improvement: remove some const reference in function signatures. `FILETIME` is a plain C struct with size of 64-bit, so it is trivially-copyable and can easily fit into a 64-bit register. It is more efficient to pass `FILETIME` by value (smaller code size).
/cc @laszlocsomor
Closes #5434.
Change-Id: I136fe4a8ce1b274a80e3206b62e6087dd0f8f5eb
PiperOrigin-RevId: 201343053
Diffstat (limited to 'src/main/cpp/util/logging.h')
0 files changed, 0 insertions, 0 deletions