diff options
| author |  Lukacs Berki <lberki@google.com> | 2016-09-21 12:14:02 +0000 |
|---|---|---|
| committer |  Laszlo Csomor <laszlocsomor@google.com> | 2016-09-21 12:18:11 +0000 |
| commit | 6c9b9938328d750c6f54764a2a8b3e25b6acfe24 (patch) | |
| tree | 64f784e8c9db806672bbae63e81159d020b6a178 /src/main/cpp/blaze.cc | |
| parent | fefd2329f4812bcb513294fdf417fc726a86ddfd (diff) | |
Remove a comment that says we can remove some obsolete code.
Spurred by Thiago's change in the area, I figured I'll try removing the PID symlink, but then I realized that this won't work, because the code currently gives precedence to the symlink, which means that if a server that writes both is replaced with a server that only writes the text file, the contents of the text file will not be read.
Also note that in Bazel, long jumps between server versions are much more possible than internally, so the cleanup is just not worth the risk, which is sad.
--
MOS_MIGRATED_REVID=133820484
Diffstat (limited to 'src/main/cpp/blaze.cc')
| -rw-r--r-- | src/main/cpp/blaze.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/main/cpp/blaze.cc b/src/main/cpp/blaze.cc index c18968d5f8..cb9208d4c9 100644 --- a/src/main/cpp/blaze.cc +++ b/src/main/cpp/blaze.cc @@ -996,8 +996,6 @@ static int GetServerPid(const string &server_dir) { // The server writes a file, but we need to handle old servers that still // write a symlink. - // TODO(lberki): Remove the readlink() call when there is no chance of an old - // server lingering around. Probably safe after 2016.06.01. int len; string pid_file = blaze_util::JoinPath(server_dir, kServerPidFile); string pid_symlink = blaze_util::JoinPath(server_dir, kServerPidSymlink); |