diff options
author | 2016-02-18 19:32:07 +0000 | |
---|---|---|
committer | 2016-02-19 08:56:56 +0000 | |
commit | 6a9163039d2189382ac70e8ca03f30dafda86722 (patch) | |
tree | 79968f4db0e43fc38e23622339d3951adf573c36 /src/java_tools | |
parent | 6e18862a2609d5b20c811488f3ab6a93d700fdd2 (diff) |
Make effectively final fields final
--
MOS_MIGRATED_REVID=114984938
Diffstat (limited to 'src/java_tools')
4 files changed, 6 insertions, 6 deletions
diff --git a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/OptionsParser.java b/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/OptionsParser.java index 36b4fbe48b..0e61b1034a 100644 --- a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/OptionsParser.java +++ b/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/OptionsParser.java @@ -36,7 +36,7 @@ import java.util.Set; * command-line flags and options files and provides them via getters. */ public final class OptionsParser { - private List<String> javacOpts = new ArrayList<>(); + private final List<String> javacOpts = new ArrayList<>(); private final Map<String, String> directJarsToTargets = new HashMap<>(); private final Map<String, String> indirectJarsToTargets = new HashMap<>(); @@ -45,7 +45,7 @@ public final class OptionsParser { private String outputDepsFile; private String outputDepsProtoFile; - private Set<String> depsArtifacts = new HashSet<>(); + private final Set<String> depsArtifacts = new HashSet<>(); private boolean strictClasspathMode; diff --git a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/dependency/StrictJavaDepsPlugin.java b/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/dependency/StrictJavaDepsPlugin.java index ec83fbf205..e8c78d51a6 100644 --- a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/dependency/StrictJavaDepsPlugin.java +++ b/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/dependency/StrictJavaDepsPlugin.java @@ -67,7 +67,7 @@ public final class StrictJavaDepsPlugin extends BlazeJavaCompilerPlugin { private static final boolean USE_COLOR = true; private ImplicitDependencyExtractor implicitDependencyExtractor; private CheckingTreeScanner checkingTreeScanner; - private DependencyModule dependencyModule; + private final DependencyModule dependencyModule; /** Marks seen compilation toplevels and their import sections */ private final Set<JCTree.JCCompilationUnit> toplevels; diff --git a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/processing/AnnotationProcessingModule.java b/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/processing/AnnotationProcessingModule.java index bbce4849bf..04861477f5 100644 --- a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/processing/AnnotationProcessingModule.java +++ b/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/plugins/processing/AnnotationProcessingModule.java @@ -43,7 +43,7 @@ public class AnnotationProcessingModule { public static class Builder { private Path sourceGenDir; private Path manifestProto; - private ImmutableSet.Builder<Path> sourceRoots = ImmutableSet.builder(); + private final ImmutableSet.Builder<Path> sourceRoots = ImmutableSet.builder(); private Builder() {} diff --git a/src/java_tools/buildjar/javatests/com/google/devtools/build/java/turbine/javac/JavacTurbineTest.java b/src/java_tools/buildjar/javatests/com/google/devtools/build/java/turbine/javac/JavacTurbineTest.java index c9d49e08ee..69c92f1f91 100644 --- a/src/java_tools/buildjar/javatests/com/google/devtools/build/java/turbine/javac/JavacTurbineTest.java +++ b/src/java_tools/buildjar/javatests/com/google/devtools/build/java/turbine/javac/JavacTurbineTest.java @@ -85,7 +85,7 @@ import javax.tools.StandardLocation; @RunWith(JUnit4.class) public class JavacTurbineTest { - @Rule public TemporaryFolder temp = new TemporaryFolder(); + @Rule public final TemporaryFolder temp = new TemporaryFolder(); Path sourcedir; List<Path> sources; @@ -93,7 +93,7 @@ public class JavacTurbineTest { Path output; Path outputDeps; - TurbineOptions.Builder optionsBuilder = TurbineOptions.builder(); + final TurbineOptions.Builder optionsBuilder = TurbineOptions.builder(); @Before public void setUp() throws IOException { |