aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/java_tools/junitrunner/java
diff options
context:
space:
mode:
authorGravatar Igal Tabachnik <igalt@wix.com>2018-02-15 02:20:10 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-02-15 02:22:05 -0800
commit3edf41b70de9bb1a8702d0342beeb2ad13898d71 (patch)
tree8828f1bd51145ad97448e35bf907e1c2d3280207 /src/java_tools/junitrunner/java
parentf58dc51a225139fabeb452eb4b88022558f29f55 (diff)
Skipping writing FILTERED tests to test.xml
This fixes #3201 by preventing tests that haven't actually run to be written to the test.xml. This is consistent with how e.g. surefire reports work, tests that were filtered out do not appear in the xml. This allows changing the Bazel plugin in such a way that does not depend on `time` being 0.0. Closes #4596. PiperOrigin-RevId: 185810400
Diffstat (limited to 'src/java_tools/junitrunner/java')
-rw-r--r--src/java_tools/junitrunner/java/com/google/testing/junit/runner/model/AntXmlResultWriter.java3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/java_tools/junitrunner/java/com/google/testing/junit/runner/model/AntXmlResultWriter.java b/src/java_tools/junitrunner/java/com/google/testing/junit/runner/model/AntXmlResultWriter.java
index 8ee4ba3a64..4c0e794fb6 100644
--- a/src/java_tools/junitrunner/java/com/google/testing/junit/runner/model/AntXmlResultWriter.java
+++ b/src/java_tools/junitrunner/java/com/google/testing/junit/runner/model/AntXmlResultWriter.java
@@ -112,6 +112,9 @@ public final class AntXmlResultWriter implements XmlResultWriter {
private void writeTestCases(XmlWriter writer, TestResult result,
Iterable<Throwable> parentFailures) throws IOException {
for (TestResult child : result.getChildResults()) {
+ if (child.getStatus() == TestResult.Status.FILTERED) {
+ continue;
+ }
if (child.getChildResults().isEmpty()) {
writeTestCase(writer, child, parentFailures);
}