aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java
diff options
context:
space:
mode:
authorGravatar Liam Miller-Cushon <cushon@google.com>2017-02-22 21:52:02 +0000
committerGravatar Yue Gan <yueg@google.com>2017-02-23 11:30:19 +0000
commit2997e2574e198ebcbff2aaf4e468077061561ab3 (patch)
tree5c764d0d0655d21f664c3bf1b73ef8c492e39a2c /src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java
parentb21339b2f43ec49af48525546f19bda09ba282bc (diff)
Filter out Blaze-specific javacopts in VanillaJavaBuilder
e.g. Error Prone flags, since VanillaJavaBuilder doesn't support them. -- PiperOrigin-RevId: 148263963 MOS_MIGRATED_REVID=148263963
Diffstat (limited to 'src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java')
-rw-r--r--src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java17
1 files changed, 15 insertions, 2 deletions
diff --git a/src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java b/src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java
index 71a702ed05..6ae2f3140a 100644
--- a/src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java
+++ b/src/java_tools/buildjar/javatests/com/google/devtools/build/buildjar/VanillaJavaBuilderTest.java
@@ -83,6 +83,8 @@ public class VanillaJavaBuilderTest {
VanillaJavaBuilderResult result =
run(
ImmutableList.of(
+ "--javacopts",
+ "-Xep:FallThrough:ERROR",
"--sources",
source.toString(),
"--source_jars",
@@ -113,12 +115,23 @@ public class VanillaJavaBuilderTest {
source,
ImmutableList.of(
"class A {", //
- "}}"),
+ " void f(int x) {",
+ " switch (x) {",
+ " case 0:",
+ " System.err.println(0);",
+ " case 1:",
+ " System.err.println(0);",
+ " }",
+ " }",
+ "}"),
UTF_8);
VanillaJavaBuilderResult result =
run(
ImmutableList.of(
+ "--javacopts",
+ "-Xlint:all",
+ "-Werror",
"--sources",
source.toString(),
"--output",
@@ -128,7 +141,7 @@ public class VanillaJavaBuilderTest {
"--classdir",
temporaryFolder.newFolder().toString()));
- assertThat(result.output()).contains("class, interface, or enum expected");
+ assertThat(result.output()).contains("possible fall-through");
assertThat(result.ok()).isFalse();
assertThat(Files.exists(output)).isFalse();
}