diff options
| author |  jmmv <jmmv@google.com> | 2017-08-25 21:14:27 +0200 |
|---|---|---|
| committer |  Vladimir Moskva <vladmos@google.com> | 2017-08-28 16:08:18 +0200 |
| commit | 3ab810b1fcaa3aaf88d39a9ce1b47917870f845d (patch) | |
| tree | 0b2fcf610353db9922e302163992a025beca0070 /src/create_embedded_tools.py | |
| parent | 658143c1b48c3ddb60f7f60544ff943486b201c9 (diff) | |
Ensure our "Another command is running" messages hold realistic PIDs.
Instead of blocking indefinitely for the server lock to become available
when other commands are running, busy-wait for the lock to be released.
This allows us to detect changes in the PID of the client that is
holding the lock, and thus lets us make our wait messages more accurate.
There have been multiple bug reports over time (especially from macOS
users) where they complain that Bazel is stuck waiting for a
non-existent PID. The code doesn't look obviously bogus, so this might
just be a case of confusion based on the printed PID. By improving the
diagnostic messages we output, we'll either make this confusion go away
or have a chance of gathering more data when/if this happens again.
This change has the side-effect of homogenizing the wait messages
printed by both the Blaze client and the Blaze server and also adds
details to know which component is printing what.
PiperOrigin-RevId: 166508406
Diffstat (limited to 'src/create_embedded_tools.py')
0 files changed, 0 insertions, 0 deletions