diff options
| author |  Googler <noreply@google.com> | 2017-08-21 20:05:58 +0200 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2017-08-22 09:14:09 +0200 |
| commit | d255dae6fcd761d4b58609dbe941d0062dcf15ea (patch) | |
| tree | ea8deb783d61372401bb34e562602b38d210756a /site | |
| parent | fedeb9d8e6a599d991a5f8efb5faf2e7c3e465a5 (diff) | |
Add recommendation to build-style.md about listing dependencies directly.
RELNOTES: None.
PiperOrigin-RevId: 165949361
Diffstat (limited to 'site')
| -rw-r--r-- | site/docs/skylark/build-style.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/site/docs/skylark/build-style.md b/site/docs/skylark/build-style.md index a74a04522f..93394a37ef 100644 --- a/site/docs/skylark/build-style.md +++ b/site/docs/skylark/build-style.md @@ -136,6 +136,12 @@ compatible with the [References to targets in the current package](#references-to-targets-in-the-current-package) section above (not by their absolute package name). +Prefer to list dependencies directly, as a single list. Putting the "common" +dependencies of several targets into a variable reduces maintainability, makes +it impossible for tools to change the dependencies of a target and can lead to +unused dependencies. + + ## Globs Do not use recursive globs (e.g., `glob(["**/*.java"])`). Recursive globs |