aboutsummaryrefslogtreecommitdiffhomepage
path: root/site/docs
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2017-06-29 01:46:58 +0200
committerGravatar Marcel Hlopko <hlopko@google.com>2017-06-29 09:34:01 +0200
commitb5873507768ae6a3995480dc820ab904841d2a9a (patch)
tree3d66a9180e22b2a985f5bed9bb6f14253bc02afd /site/docs
parent8355237f65842d9df45b51cdfaebda9bb44c3a79 (diff)
Update aspect documentation to reflect aspect parameters.
RELNOTES: none PiperOrigin-RevId: 160467549
Diffstat (limited to 'site/docs')
-rw-r--r--site/docs/skylark/aspects.md12
1 files changed, 8 insertions, 4 deletions
diff --git a/site/docs/skylark/aspects.md b/site/docs/skylark/aspects.md
index 5dcaf1bedf..2ec6d5a465 100644
--- a/site/docs/skylark/aspects.md
+++ b/site/docs/skylark/aspects.md
@@ -93,10 +93,14 @@ Just like a rule, an aspect has an implementation function. ``attr_aspects``
specify the aspect's propagation set: a list of attributes of rules along which
the aspect propagates.
-``attrs`` defines a set of attributes for aspects. Aspects are only allowed
-to have private attributes of types ``label`` or ``label_list``. Attributes
-can be used to specify dependencies on tools or libraries that are needed
-for actions generated by aspects.
+``attrs`` defines a set of attributes for aspects. Aspects are allowed
+to have private attributes of types ``label`` or ``label_list``. Private label
+attributes can be used to specify dependencies on tools or libraries that are
+needed for actions generated by aspects. Aspects may also have normal attributes
+of type ``string``, called parameters, so long as ``values`` is specified. Any
+string attributes must match string attributes on the Skylark rule requesting
+the aspect, and they inherit their value from the rule. Aspects with parameters
+cannot be requested on the bazel command-line.
### Implementation functions