diff options
author | 2017-10-23 17:01:35 +0200 | |
---|---|---|
committer | 2017-10-23 17:16:26 +0200 | |
commit | 4256ce1915c69bb8a8cee0b5c09a094768b7cd02 (patch) | |
tree | d47d8ae04f078cbca4e92a3c282f096ff9450e48 /site/docs | |
parent | c6fd7b22a056f38ae717ad87016f2f76df25998b (diff) |
Automated rollback of commit 1b98de65873054b148ced772cfa827a7bfb5ad9a.
*** Reason for rollback ***
If the 'set' function was used in a .bzl file but not called, --incompatible_disallow_set_constructor=True would allow the load of that .bzl file without error, but this change removes the 'set' function so loading that bzl file is an error.
Example failure: https://ci.bazel.io/blue/organizations/jenkins/Global%2FTensorFlow/detail/TensorFlow/245/pipeline/
*** Original change description ***
Remove the deprecated set constructor from Skylark
The `set` constructor used to be deprecated, but it was still possible to use
it by providing --incompatible_disallow_set_constructor=false.
RELNOTES[INC]: The flag --incompatible_disallow_set_constructor is no longer
available, the deprecated `set` constructor is not available anymore.
PiperOrigin-RevId: 173115983
Diffstat (limited to 'site/docs')
-rw-r--r-- | site/docs/skylark/backward-compatibility.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/site/docs/skylark/backward-compatibility.md b/site/docs/skylark/backward-compatibility.md index cb9991040d..032588b437 100644 --- a/site/docs/skylark/backward-compatibility.md +++ b/site/docs/skylark/backward-compatibility.md @@ -30,6 +30,7 @@ To check if your code will be compatible with future releases you can: The following are the backward incompatible changes that are implemented and guarded behind flags in the current release: +* [Set constructor](#set-constructor) * [Keyword-only arguments](#keyword-only-arguments) * [Mutating `+=`](#mutating) * [Dictionary concatenation](#dictionary-concatenation) @@ -43,6 +44,18 @@ guarded behind flags in the current release: * [New actions API](#new-actions-api) * [Checked arithmetic](#checked-arithmetic) +### Set constructor + +We are removing the `set` constructor. Use `depset` instead. `set` and `depset` +are equivalent, you just need to do search and replace to update the old code. + +We are doing this to reduce confusion between the specialized +[depset](depsets.md) data structure and Python's set datatype. + +* Flag: `--incompatible_disallow_set_constructor` +* Default: `true` + + ### Keyword-only arguments Keyword-only parameters are parameters that can be called only using their name. |