diff options
| author |  Klaus Aehlig <aehlig@google.com> | 2016-09-30 11:15:07 +0000 |
|---|---|---|
| committer |  Yun Peng <pcloudy@google.com> | 2016-09-30 14:11:19 +0000 |
| commit | d59bcb6333be731d82c51c20211ecabebe194f19 (patch) | |
| tree | 490f480f61833cffad39127d24dac613a86bdec8 /site/designs | |
| parent | 95a87d0d8b26d9ca7d8d957dc23373b6a89e3d68 (diff) | |
Rollback of commit c5545fd0896f3c602a9be0986debed6f0c9c662d.
*** Reason for rollback ***
Roll-forward with appropriate fixes: --action_env is a "build" option,
not a "common" option. Moreover, also inherit the corresponding variables
for tests from the effective action environment.
Also fix the corresponding error in the design document.
*** Original change description ***
Automated [] rollback of commit 96d46280bc5a4803ba2242a4ad16939f85a3b212.
*** Reason for rollback ***
Broke installation on latest release.
Fixes #1846
*** Original change description ***
Reintroduce .bazelrc and set --action_env defaults
Shipping a .bazelrc was removed in 009b48bcfaf4ebb17f9ab03bea9036cfa3c12ff0.
However, as per our "Specifying environment variables for actions" design
document, we want to ship a global rc file specifying the common environment
variables to be inherited. So revert that change and add the desired entries
to the global bazelrc file we're shipping.
***
--
MOS_MIGRATED_REVID=134769063
Diffstat (limited to 'site/designs')
| -rw-r--r-- | site/designs/_posts/2016-06-21-environment.md | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/site/designs/_posts/2016-06-21-environment.md b/site/designs/_posts/2016-06-21-environment.md index e8e42f816f..82faa3f08d 100644 --- a/site/designs/_posts/2016-06-21-environment.md +++ b/site/designs/_posts/2016-06-21-environment.md @@ -162,9 +162,11 @@ transition to the new set up, the global Bazel rc-file provided by upstream will have the following content. ``` -common --action_env=PATH -common --action_env=LD_LIBRARY_PATH -common --action_env=TMPDIR +build --action_env=PATH +build --action_env=LD_LIBRARY_PATH +build --action_env=TMPDIR +build --test_env=PATH +build --test_env=LD_LIBRARY_PATH ``` |