diff options
| author |  laszlocsomor <laszlocsomor@google.com> | 2018-07-05 01:58:06 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-07-05 02:00:15 -0700 |
| commit | f11c6bcab87ee8927e23a23d2300900a0922616d (patch) | |
| tree | 64b31cedc598400dbeabd00f2fa05f7d875c8b9e /scripts | |
| parent | 195c4e4c8fb3d4c6b1b3790b07266b0a5ff51d80 (diff) | |
python tools: ensure files are closed
Use the "with" statement to open files in various
Python scripts used by Bazel, to ensure these
files are closed eagerly.
See https://github.com/bazelbuild/bazel/issues/5512
RELNOTES: none
PiperOrigin-RevId: 203346678
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/packages/debian/generate_changelog.py | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/scripts/packages/debian/generate_changelog.py b/scripts/packages/debian/generate_changelog.py index f1945fbbe1..31f69644b6 100644 --- a/scripts/packages/debian/generate_changelog.py +++ b/scripts/packages/debian/generate_changelog.py @@ -19,23 +19,23 @@ import sys def main(input_file, output_file): - changelog_out = open(output_file, "w") - version = None - with open(input_file, "r") as status_file: - for line in status_file: - line = line.strip() - if line.startswith("RELEASE_NAME "): - version = line[len("RELEASE_NAME "):].strip() + with open(output_file, "w") as changelog_out: + version = None + with open(input_file, "r") as status_file: + for line in status_file: + line = line.strip() + if line.startswith("RELEASE_NAME "): + version = line[len("RELEASE_NAME "):].strip() - if version: - changelog_out.write("bazel (%s) unstable; urgency=low\n" % version) - changelog_out.write("\n Bumped Bazel version to %s.\n" % version) - else: - changelog_out.write("bazel (0.1.0~HEAD) unstable; urgency=low\n") - changelog_out.write("\n Development version\n") - changelog_out.write( - "\n -- The Bazel Authors <bazel-dev@googlegroups.com> %s\n\n" % - datetime.now().strftime("%a, %d %b %Y %H:%M:%S +0100")) + if version: + changelog_out.write("bazel (%s) unstable; urgency=low\n" % version) + changelog_out.write("\n Bumped Bazel version to %s.\n" % version) + else: + changelog_out.write("bazel (0.1.0~HEAD) unstable; urgency=low\n") + changelog_out.write("\n Development version\n") + changelog_out.write( + "\n -- The Bazel Authors <bazel-dev@googlegroups.com> %s\n\n" % + datetime.now().strftime("%a, %d %b %Y %H:%M:%S +0100")) if __name__ == "__main__": |