aboutsummaryrefslogtreecommitdiffhomepage
path: root/scripts
diff options
context:
space:
mode:
authorGravatar janakr <janakr@google.com>2018-04-01 19:12:26 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-04-01 19:14:01 -0700
commit52859b454b4426e98d3106c95e5b16e56b5cd437 (patch)
treee7e44cb27fa06fb553ed904a2bb14ea60f86e4a8 /scripts
parentf54d7e5293cc40ce3507a9adef530e46ab817585 (diff)
Change profiling to only accept strings for its "description" argument. Profiling can hold onto objects for the duration of the build, and some of those objects may be temporary that should not be persisted. In particular, UnixGlob and its inner classes should not outlive loading and analysis. For the most part, care was taken in this CL to only use strings that required no additional construction, mainly to minimize garbage (retaining references to newly created strings is not as great a concern since only the strings corresponding to the slowest K tasks are retained, for some relatively small values of K). Action descriptions for actually executing actions are eagerly expanded because that work is minimal compared to the work of actually executing an action.
PiperOrigin-RevId: 191251488
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions