diff options
| author |  László Csomor <laszlocsomor@google.com> | 2017-10-09 09:11:08 +0200 |
|---|---|---|
| committer |  Klaus Aehlig <aehlig@google.com> | 2017-10-09 10:06:54 +0200 |
| commit | aa0299092d8a4692cb89be2d9e2e890a2e8d7aeb (patch) | |
| tree | 3297a19b2f533ec9046cd41377f589034756d1e2 /scripts/bootstrap | |
| parent | b45d5f536048db0e568e16417f4fb1d50f01e1ac (diff) | |
Clean up TODOs.
In this commit:
* buildenv.sh: restore its state to that as of
commit 511c35b46cead500d4e76706e0a709e50995ceba
* CommonCommandOptions.java: remove a deprecated
no-op flag
* WindowsPathFragment.java: implement an
ASCII-only isLetter function, use that instead
of Character.isLetter, because the latter
returns true for some Unicode characters too
* bazel_bootstrap_distfile_test: remove logging
that we no longer need, since the bugfix for
issue #3618 will be pushed to GitHub later today
Change-Id: Ibda70219e974f0c47bc82addc647d8951f4bd701
PiperOrigin-RevId: 171498977
Diffstat (limited to 'scripts/bootstrap')
| -rwxr-xr-x | scripts/bootstrap/buildenv.sh | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/scripts/bootstrap/buildenv.sh b/scripts/bootstrap/buildenv.sh index cbb1365ef9..9301483180 100755 --- a/scripts/bootstrap/buildenv.sh +++ b/scripts/bootstrap/buildenv.sh @@ -161,9 +161,7 @@ function tempdir() { local DIR="$(mktemp -d "${tmp%%/}/bazel_XXXXXXXX")" mkdir -p "${DIR}" local DIRBASE=$(basename "${DIR}") - # TODO(laszlocsomor): Remove the "[ -n ... ] && echo ... ;" part from the - # following command after we fixed https://github.com/bazelbuild/bazel/issues/3618. - eval "cleanup_tempdir_${DIRBASE}() { [ -n \"\$TEST_TMPDIR\" ] && echo \"DEBUG[$0 (\$(date))] deleting ($DIR)\" ; rm -rf '${DIR}' >&/dev/null || true ; }" + eval "cleanup_tempdir_${DIRBASE}() { rm -rf '${DIR}' >&/dev/null || true ; }" atexit cleanup_tempdir_${DIRBASE} NEW_TMPDIR="${DIR}" } |