diff options
| author |  ulfjack <ulfjack@google.com> | 2017-04-06 10:25:16 +0000 |
|---|---|---|
| committer |  Marcel Hlopko <hlopko@google.com> | 2017-04-06 17:51:22 +0200 |
| commit | 1a328e34e122d308f4d1a4f548823130b862a0a4 (patch) | |
| tree | f7da762a8f751a9d87de7754c81cd6b495681a22 /LICENSE.txt | |
| parent | 30909cff5e7c2882f195f21e5d47ed1906c874af (diff) | |
Explicitly document the state transition on MetadataHandler
The ActionMetadataHandler does an explicit state transition on
discardOutputMetadata. Before the call, it may be used for action cache
checking, and after the call it may be updated with execution results.
Several of the methods now throw if they're used incorrectly, so I had to
refactor the control flow in ActionExecutionFunction to correctly call
discardOutputMetadata on the MetadataHandler in all cases. I discovered a
resource leak (of FileOutErr) in IncludeParseFunction while I was at it, so
I plugged that as well.
One step towards #1525.
PiperOrigin-RevId: 152363982
Diffstat (limited to 'LICENSE.txt')
0 files changed, 0 insertions, 0 deletions