aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Ulf Adams <ulfjack@google.com>2015-09-25 21:16:42 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-09-28 11:39:37 +0000
commitfbeb09d518e81e92113a2663c6c975fa598b9d50 (patch)
tree1c62adb5f1d92e32303bc76358f69d9fbb583d8b
parent9d43bd0218bdd60f30b462d31c2cc387b4bfa594 (diff)
Make explicit that the SkyframeTransitivePackageLoader needs an EventHandler.
-- MOS_MIGRATED_REVID=103975222
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java14
1 files changed, 10 insertions, 4 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
index 38748a9f6e..07272529d9 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
@@ -279,7 +279,7 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
this.tsgm = tsgm;
this.workspaceStatusActionFactory = workspaceStatusActionFactory;
this.packageManager = new SkyframePackageManager(
- new SkyframePackageLoader(), new SkyframeTransitivePackageLoader(),
+ new SkyframePackageLoader(), new SkyframeTransitivePackageLoader(reporter),
new SkyframeTargetPatternEvaluator(this), syscalls, cyclesReporter, pkgLocator,
numPackagesLoaded, this);
this.errorEventListener = Preconditions.checkNotNull(reporter);
@@ -1361,10 +1361,17 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
@VisibleForTesting
public TransitivePackageLoader pkgLoader() {
checkActive();
- return new SkyframeLabelVisitor(new SkyframeTransitivePackageLoader(), cyclesReporter);
+ return new SkyframeLabelVisitor(
+ new SkyframeTransitivePackageLoader(errorEventListener), cyclesReporter);
}
class SkyframeTransitivePackageLoader {
+ private final EventHandler eventHandler;
+
+ SkyframeTransitivePackageLoader(EventHandler eventHandler) {
+ this.eventHandler = eventHandler;
+ }
+
/**
* Loads the specified {@link TransitiveTargetValue}s.
*/
@@ -1399,7 +1406,7 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
valueNames,
false,
ResourceUsage.getAvailableProcessors(),
- errorEventListener);
+ eventHandler);
Preconditions.checkState(
!result.hasError(), "unexpected errors: %s", result.errorMap());
Set<Package> packages = Sets.newHashSet();
@@ -1414,7 +1421,6 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
} catch (Exception e) {
throw new IllegalStateException(e);
}
-
}
}