Rollback of commit 12bad3af0eade9c4b79d76f9e1c950ad2e3214c2.

*** Reason for rollback ***

Breaks ci.bazel.io: http://ci.bazel.io/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=darwin-x86_64/256/console

*** Original change description ***

Open source PackageCacheTest.

--
MOS_MIGRATED_REVID=110352000

2 files changed, 0 insertions, 619 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/BUILD b/src/test/java/com/google/devtools/build/lib/BUILD
index 3f371a9a82..44d2569c0d 100644
--- a/src/test/java/com/google/devtools/build/lib/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/BUILD
@@ -596,7 +596,6 @@ java_test(
     ),
     args = ["com.google.devtools.build.lib.AllTests"],
     deps = [
-        ":analysis_testutil",
         ":packages_testutil",
         ":test_runner",
         "//src/main/java/com/google/devtools/build/lib:bazel-rules",
diff --git a/src/test/java/com/google/devtools/build/lib/pkgcache/PackageCacheTest.java b/src/test/java/com/google/devtools/build/lib/pkgcache/PackageCacheTest.java
deleted file mode 100644
index 9e268a78a1..0000000000
--- a/src/test/java/com/google/devtools/build/lib/pkgcache/PackageCacheTest.java
+++ /dev/null
@@ -1,618 +0,0 @@
-// Copyright 2015 The Bazel Authors. All rights reserved.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//    http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-package com.google.devtools.build.lib.pkgcache;
-
-import static com.google.common.truth.Truth.assertThat;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNotSame;
-import static org.junit.Assert.assertSame;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
-
-import com.google.common.base.Predicates;
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.ImmutableSet;
-import com.google.devtools.build.lib.analysis.BlazeDirectories;
-import com.google.devtools.build.lib.analysis.ConfiguredRuleClassProvider;
-import com.google.devtools.build.lib.analysis.util.AnalysisMock;
-import com.google.devtools.build.lib.cmdline.Label;
-import com.google.devtools.build.lib.cmdline.PackageIdentifier;
-import com.google.devtools.build.lib.events.Event;
-import com.google.devtools.build.lib.packages.BuildFileContainsErrorsException;
-import com.google.devtools.build.lib.packages.ConstantRuleVisibility;
-import com.google.devtools.build.lib.packages.NoSuchPackageException;
-import com.google.devtools.build.lib.packages.NoSuchTargetException;
-import com.google.devtools.build.lib.packages.Package;
-import com.google.devtools.build.lib.packages.PackageFactory;
-import com.google.devtools.build.lib.packages.Preprocessor;
-import com.google.devtools.build.lib.packages.Rule;
-import com.google.devtools.build.lib.packages.Target;
-import com.google.devtools.build.lib.packages.util.MockToolsConfig;
-import com.google.devtools.build.lib.skyframe.DiffAwareness;
-import com.google.devtools.build.lib.skyframe.PrecomputedValue;
-import com.google.devtools.build.lib.skyframe.SequencedSkyframeExecutor;
-import com.google.devtools.build.lib.skyframe.SkyValueDirtinessChecker;
-import com.google.devtools.build.lib.skyframe.SkyframeExecutor;
-import com.google.devtools.build.lib.syntax.BuildFileAST;
-import com.google.devtools.build.lib.testutil.FoundationTestCase;
-import com.google.devtools.build.lib.testutil.MoreAsserts;
-import com.google.devtools.build.lib.testutil.TestRuleClassProvider;
-import com.google.devtools.build.lib.util.BlazeClock;
-import com.google.devtools.build.lib.util.io.TimestampGranularityMonitor;
-import com.google.devtools.build.lib.vfs.ModifiedFileSet;
-import com.google.devtools.build.lib.vfs.Path;
-import com.google.devtools.build.lib.vfs.PathFragment;
-import com.google.devtools.build.skyframe.SkyFunction;
-import com.google.devtools.build.skyframe.SkyFunctionName;
-import com.google.devtools.common.options.OptionsParser;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.JUnit4;
-
-import java.io.IOException;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
-import java.util.UUID;
-
-/**
- * Tests for package loading.
- */
-@RunWith(JUnit4.class)
-public class PackageCacheTest extends FoundationTestCase {
-
-  private ConfiguredRuleClassProvider ruleClassProvider;
-  private SkyframeExecutor skyframeExecutor;
-
-  @Before
-  public final void initializeSkyframExecutor() throws Exception {
-    ruleClassProvider = TestRuleClassProvider.getRuleClassProvider();
-    skyframeExecutor =
-        SequencedSkyframeExecutor.create(
-            new PackageFactory(ruleClassProvider),
-            new TimestampGranularityMonitor(BlazeClock.instance()),
-            new BlazeDirectories(outputBase, outputBase, rootDirectory),
-            null, /* BinTools */
-            null, /* workspaceStatusActionFactory */
-            ruleClassProvider.getBuildInfoFactories(),
-            ImmutableList.<DiffAwareness.Factory>of(),
-            Predicates.<PathFragment>alwaysFalse(),
-            Preprocessor.Factory.Supplier.NullSupplier.INSTANCE,
-            ImmutableMap.<SkyFunctionName, SkyFunction>of(),
-            ImmutableList.<PrecomputedValue.Injected>of(),
-            ImmutableList.<SkyValueDirtinessChecker>of());
-    skyframeExecutor.preparePackageLoading(
-        new PathPackageLocator(outputBase, ImmutableList.of(rootDirectory)),
-        ConstantRuleVisibility.PUBLIC, true, 7, "",
-        UUID.randomUUID());
-    setUpSkyframe(parsePackageCacheOptions());
-  }
-
-  private void setUpSkyframe(PackageCacheOptions packageCacheOptions) {
-    PathPackageLocator pkgLocator = PathPackageLocator.create(
-        null, packageCacheOptions.packagePath, reporter, rootDirectory, rootDirectory);
-    skyframeExecutor.preparePackageLoading(pkgLocator,
-        packageCacheOptions.defaultVisibility, true,
-        7, ruleClassProvider.getDefaultsPackageContent(),
-        UUID.randomUUID());
-    skyframeExecutor.setDeletedPackages(ImmutableSet.copyOf(packageCacheOptions.deletedPackages));
-  }
-
-  private PackageCacheOptions parsePackageCacheOptions(String... options) throws Exception {
-    OptionsParser parser = OptionsParser.newOptionsParser(PackageCacheOptions.class);
-    parser.parse(new String[] { "--default_visibility=public" });
-    parser.parse(options);
-    return parser.getOptions(PackageCacheOptions.class);
-  }
-
-  protected void setOptions(String... options) throws Exception {
-    setUpSkyframe(parsePackageCacheOptions(options));
-  }
-
-  private PackageManager getPackageManager() {
-    return skyframeExecutor.getPackageManager();
-  }
-
-  private void invalidatePackages() throws InterruptedException {
-    skyframeExecutor.invalidateFilesUnderPathForTesting(
-        reporter, ModifiedFileSet.EVERYTHING_MODIFIED, rootDirectory);
-  }
-
-  private Package getPackage(String packageName)
-      throws NoSuchPackageException, InterruptedException {
-    return getPackageManager().getPackage(reporter,
-        PackageIdentifier.createInDefaultRepo(packageName));
-  }
-
-  private Target getTarget(Label label)
-      throws NoSuchPackageException, NoSuchTargetException, InterruptedException {
-    return getPackageManager().getTarget(reporter, label);
-  }
-
-  private Target getTarget(String label) throws Exception {
-    return getTarget(Label.parseAbsolute(label));
-  }
-
-  private void createPkg1() throws IOException {
-    scratch.file("pkg1/BUILD", "cc_library(name = 'foo') # a BUILD file");
-  }
-
-  // Check that a substring is present in an error message.
-  private void checkGetPackageFails(String packageName, String expectedMessage) throws Exception {
-    try {
-      getPackage(packageName);
-      fail();
-    } catch (NoSuchPackageException e) {
-      assertThat(e.getMessage()).contains(expectedMessage);
-    }
-  }
-
-  @Test
-  public void testGetPackage() throws Exception {
-    createPkg1();
-    Package pkg1 = getPackage("pkg1");
-    assertEquals("pkg1", pkg1.getName());
-    assertEquals("/workspace/pkg1/BUILD",
-                 pkg1.getFilename().toString());
-    assertSame(pkg1, getPackageManager().getPackage(reporter,
-        PackageIdentifier.createInDefaultRepo("pkg1")));
-  }
-
-  @Test
-  public void testASTIsNotRetained() throws Exception {
-    createPkg1();
-    Package pkg1 = getPackage("pkg1");
-    MoreAsserts.assertInstanceOfNotReachable(pkg1, BuildFileAST.class);
-  }
-
-  @Test
-  public void testGetNonexistentPackage() throws Exception {
-    checkGetPackageFails("not-there",
-                         "no such package 'not-there': "
-                         + "BUILD file not found on package path");
-  }
-
-  @Test
-  public void testGetPackageWithInvalidName() throws Exception {
-    scratch.file("invalidpackagename&42/BUILD", "cc_library(name = 'foo') # a BUILD file");
-    checkGetPackageFails(
-        "invalidpackagename&42",
-        "no such package 'invalidpackagename&42': Invalid package name 'invalidpackagename&42'");
-  }
-
-  @Test
-  public void testGetTarget() throws Exception {
-    createPkg1();
-    Label label = Label.parseAbsolute("//pkg1:foo");
-    Target target = getTarget(label);
-    assertEquals(label, target.getLabel());
-  }
-
-  @Test
-  public void testGetNonexistentTarget() throws Exception {
-    createPkg1();
-    try {
-      getTarget("//pkg1:not-there");
-      fail();
-    } catch (NoSuchTargetException e) {
-      assertThat(e).hasMessage("no such target '//pkg1:not-there': target 'not-there' "
-          + "not declared in package 'pkg1' defined by /workspace/pkg1/BUILD");
-    }
-  }
-
-  /**
-   * A missing package is one for which no BUILD file can be found.  The
-   * PackageCache caches failures of this kind until the next sync.
-   */
-  @Test
-  public void testRepeatedAttemptsToParseMissingPackage() throws Exception {
-    checkGetPackageFails("missing",
-                         "no such package 'missing': "
-                         + "BUILD file not found on package path");
-
-    // Still missing:
-    checkGetPackageFails("missing",
-                         "no such package 'missing': "
-                         + "BUILD file not found on package path");
-
-    // Update the BUILD file on disk so "missing" is no longer missing:
-    scratch.file("missing/BUILD",
-                 "# an ok build file");
-
-    // Still missing:
-    checkGetPackageFails("missing",
-                         "no such package 'missing': "
-                         + "BUILD file not found on package path");
-
-    invalidatePackages();
-
-    // Found:
-    Package missing = getPackage("missing");
-
-    assertEquals("missing", missing.getName());
-  }
-
-  /**
-   * A broken package is one that exists but contains lexer/parser/evaluator errors. The
-   * PackageCache only makes one attempt to parse each package once found.
-   *
-   * <p>Depending on the strictness of the PackageFactory, parsing a broken package may cause a
-   * Package object to be returned (possibly missing some rules) or an exception to be thrown. For
-   * this test we need that strict behavior.
-   *
-   * <p>Note: since the PackageCache.setStrictPackageCreation method was deleted (since it wasn't
-   * used by any significant clients) creating a "broken" build file got trickier--syntax errors are
-   * not enough.  For now, we create an unreadable BUILD file, which will cause an IOException to be
-   * thrown. This test seems less valuable than it once did.
-   */
-  @Test
-  public void testParseBrokenPackage() throws Exception {
-    reporter.removeHandler(failFastHandler);
-
-    Path brokenBuildFile = scratch.file("broken/BUILD");
-    brokenBuildFile.setReadable(false);
-
-    try {
-      getPackage("broken");
-      fail();
-    } catch (BuildFileContainsErrorsException e) {
-      assertThat(e.getMessage()).contains("/workspace/broken/BUILD (Permission denied)");
-    }
-    eventCollector.clear();
-
-    // Update the BUILD file on disk so "broken" is no longer broken:
-    scratch.overwriteFile("broken/BUILD",
-                 "# an ok build file");
-
-    invalidatePackages(); //  resets cache of failures
-
-    Package broken = getPackage("broken");
-    assertEquals("broken", broken.getName());
-    assertNoEvents();
-  }
-
-  @Test
-  public void testPackageInErrorReloadedWhenFixed() throws Exception {
-    reporter.removeHandler(failFastHandler);
-    Path build = scratch.file("a/BUILD", "cc_library(name='a', feet='stinky')");
-    build.setLastModifiedTime(1);
-    Package a1 = getPackage("a");
-    assertTrue(a1.containsErrors());
-    assertContainsEvent("//a:a: no such attribute 'feet'");
-
-    eventCollector.clear();
-    build.delete();
-    build = scratch.file("a/BUILD", "cc_library(name='a', srcs=['a.cc'])");
-    build.setLastModifiedTime(2);
-    invalidatePackages();
-    Package a2 = getPackage("a");
-    assertNotSame(a1, a2);
-    assertFalse(a2.containsErrors());
-    assertNoEvents();
-  }
-
-  @Test
-  public void testModifiedBuildFileCausesReloadAfterSync() throws Exception {
-    Path path = scratch.file("pkg/BUILD",
-                             "cc_library(name = 'foo')");
-    path.setLastModifiedTime(1000);
-
-    Package oldPkg = getPackage("pkg");
-    // modify BUILD file (and change its timestamp)
-    path.delete();
-    scratch.file("pkg/BUILD", "cc_library(name = 'bar')");
-    path.setLastModifiedTime(999); // earlier; mtime doesn't have to advance
-    assertSame(oldPkg, getPackage("pkg")); // change not yet visible
-
-    invalidatePackages();
-
-    Package newPkg = getPackage("pkg");
-    assertNotSame(oldPkg, newPkg);
-    assertNotNull(newPkg.getTarget("bar"));
-  }
-
-  @Test
-  public void testTouchedBuildFileCausesReloadAfterSync() throws Exception {
-    Path path = scratch.file("pkg/BUILD",
-                             "cc_library(name = 'foo')");
-    path.setLastModifiedTime(1000);
-
-    Package oldPkg = getPackage("pkg");
-    path.setLastModifiedTime(1001);
-    assertSame(oldPkg, getPackage("pkg")); // change not yet visible
-
-    invalidatePackages();
-
-    Package newPkg = getPackage("pkg");
-    assertNotSame(oldPkg, newPkg);
-  }
-
-  @Test
-  public void testMovedBuildFileCausesReloadAfterSync() throws Exception {
-    Path buildFile1 = scratch.file("pkg/BUILD",
-                                  "cc_library(name = 'foo')");
-    Path buildFile2 = scratch.file("/otherroot/pkg/BUILD",
-                                  "cc_library(name = 'bar')");
-    setOptions("--package_path=/workspace:/otherroot");
-
-    Package oldPkg = getPackage("pkg");
-    assertSame(oldPkg, getPackage("pkg")); // change not yet visible
-    assertEquals(buildFile1, oldPkg.getFilename());
-    assertEquals(rootDirectory, oldPkg.getSourceRoot());
-
-    buildFile1.delete();
-    invalidatePackages();
-
-    Package newPkg = getPackage("pkg");
-    assertNotSame(oldPkg, newPkg);
-    assertEquals(buildFile2, newPkg.getFilename());
-    assertEquals(scratch.dir("/otherroot"), newPkg.getSourceRoot());
-
-    // TODO(bazel-team): (2009) test BUILD file moves in the other direction too.
-  }
-
-  private Path rootDir1;
-  private Path rootDir2;
-
-  private void setUpCacheWithTwoRootLocator() throws Exception {
-    // Root 1:
-    //   /a/BUILD
-    //   /b/BUILD
-    //   /c/d
-    //   /c/e
-    //
-    // Root 2:
-    //   /b/BUILD
-    //   /c/BUILD
-    //   /c/d/BUILD
-    //   /f/BUILD
-    //   /f/g
-    //   /f/g/h/BUILD
-
-    rootDir1 = scratch.dir("/workspace");
-    rootDir2 = scratch.dir("/otherroot");
-
-    createBuildFile(rootDir1, "a", "foo.txt", "bar/foo.txt");
-    createBuildFile(rootDir1, "b", "foo.txt", "bar/foo.txt");
-
-    rootDir1.getRelative("c").createDirectory();
-    rootDir1.getRelative("c/d").createDirectory();
-    rootDir1.getRelative("c/e").createDirectory();
-
-    createBuildFile(rootDir2, "c", "d", "d/foo.txt", "foo.txt", "bar/foo.txt", "e", "e/foo.txt");
-    createBuildFile(rootDir2, "c/d", "foo.txt");
-    createBuildFile(rootDir2, "f", "g/foo.txt", "g/h", "g/h/foo.txt", "foo.txt");
-    createBuildFile(rootDir2, "f/g/h", "foo.txt");
-
-    setOptions("--package_path=/workspace:/otherroot");
-  }
-
-  protected Path createBuildFile(Path workspace, String packageName,
-      String... targets) throws IOException {
-    String[] lines = new String[targets.length];
-
-    for (int i = 0; i < targets.length; i++) {
-      lines[i] = "sh_library(name='" + targets[i] + "')";
-    }
-
-    return scratch.file(workspace + "/" + packageName + "/BUILD", lines);
-  }
-
-  private void assertLabelValidity(boolean expected, String labelString)
-      throws Exception {
-    Label label = Label.parseAbsolute(labelString);
-
-    boolean actual = false;
-    String error = null;
-    try {
-      getTarget(label);
-      actual = true;
-    } catch (NoSuchPackageException | NoSuchTargetException e) {
-      error = e.getMessage();
-    }
-    if (actual != expected) {
-      fail("assertLabelValidity(" + label + ") "
-           + actual + ", not equal to expected value " + expected
-           + " (error=" + error + ")");
-    }
-  }
-
-  private void assertPackageLoadingFails(String pkgName, String expectedError) throws Exception {
-    Package pkg = getPackage(pkgName);
-    assertTrue(pkg.containsErrors());
-    assertContainsEvent(expectedError);
-  }
-
-  @Test
-  public void testLocationForLabelCrossingSubpackage() throws Exception {
-    scratch.file("e/f/BUILD");
-    scratch.file("e/BUILD",
-        "# Whatever",
-        "filegroup(name='fg', srcs=['f/g'])");
-    reporter.removeHandler(failFastHandler);
-    List<Event> events = getPackage("e").getEvents();
-    assertThat(events).hasSize(1);
-    assertEquals(2, events.get(0).getLocation().getStartLineAndColumn().getLine());
-  }
-
-  /** Static tests (i.e. no changes to filesystem, nor calls to sync). */
-  @Test
-  public void testLabelValidity() throws Exception {
-    reporter.removeHandler(failFastHandler);
-    setUpCacheWithTwoRootLocator();
-
-    scratch.file(rootDir2 + "/c/d/foo.txt");
-
-    assertLabelValidity(true, "//a:foo.txt");
-    assertLabelValidity(true, "//a:bar/foo.txt");
-    assertLabelValidity(false, "//a/bar:foo.txt"); //  no such package a/bar
-
-    assertLabelValidity(true, "//b:foo.txt");
-    assertLabelValidity(true, "//b:bar/foo.txt");
-    assertLabelValidity(false, "//b/bar:foo.txt"); // no such package b/bar
-
-    assertLabelValidity(true, "//c:foo.txt");
-    assertLabelValidity(true, "//c:bar/foo.txt");
-    assertLabelValidity(false, "//c/bar:foo.txt"); // no such package c/bar
-
-    assertLabelValidity(true, "//c:foo.txt");
-
-    assertLabelValidity(false, "//c:d/foo.txt"); // crosses boundary of c/d
-    assertLabelValidity(true, "//c/d:foo.txt");
-
-    assertLabelValidity(true, "//c:foo.txt");
-    assertLabelValidity(true, "//c:e");
-    assertLabelValidity(true, "//c:e/foo.txt");
-    assertLabelValidity(false, "//c/e:foo.txt"); // no such package c/e
-
-    assertLabelValidity(true, "//f:foo.txt");
-    assertLabelValidity(true, "//f:g/foo.txt");
-    assertLabelValidity(false, "//f/g:foo.txt"); // no such package f/g
-    assertLabelValidity(false, "//f:g/h/foo.txt"); // crosses boundary of f/g/h
-    assertLabelValidity(false, "//f/g:h/foo.txt"); // no such package f/g
-    assertLabelValidity(true, "//f/g/h:foo.txt");
-  }
-
-  /** Dynamic tests of label validity. */
-  @Test
-  public void testAddedBuildFileCausesLabelToBecomeInvalid() throws Exception {
-    reporter.removeHandler(failFastHandler);
-    scratch.file("pkg/BUILD",
-                 "           cc_library(name = 'foo', ",
-                 "           srcs = ['x/y.cc'])");
-
-    assertLabelValidity(true, "//pkg:x/y.cc");
-
-    // The existence of this file makes 'x/y.cc' an invalid reference.
-    scratch.file("pkg/x/BUILD");
-
-    // but not yet...
-    assertLabelValidity(true, "//pkg:x/y.cc");
-
-    invalidatePackages();
-
-    // now:
-    assertPackageLoadingFails("pkg",
-        "Label '//pkg:x/y.cc' crosses boundary of subpackage 'pkg/x' "
-        + "(perhaps you meant to put the colon here: '//pkg/x:y.cc'?)");
-  }
-
-  @Test
-  public void testDeletedPackages() throws Exception {
-    reporter.removeHandler(failFastHandler);
-    setUpCacheWithTwoRootLocator();
-    createBuildFile(rootDir1, "c", "d/x");
-    // Now package c exists in both roots, and c/d exists in only in the second
-    // root.  It's as if we've merged c and c/d in the first root.
-
-    // c/d is still a subpackage--found in the second root:
-    assertEquals(rootDir2.getRelative("c/d/BUILD"),
-                 getPackage("c/d").getFilename());
-
-    // Subpackage labels are still valid...
-    assertLabelValidity(true, "//c/d:foo.txt");
-    // ...and this crosses package boundaries:
-    assertLabelValidity(false, "//c:d/x");
-    assertPackageLoadingFails("c",
-        "Label '//c:d/x' crosses boundary of subpackage 'c/d' (have you deleted c/d/BUILD? "
-        + "If so, use the --deleted_packages=c/d option)");
-
-    assertTrue(getPackageManager().isPackage(
-        reporter, PackageIdentifier.createInDefaultRepo("c/d")));
-
-    setOptions("--deleted_packages=c/d");
-    invalidatePackages();
-
-    assertFalse(getPackageManager().isPackage(
-        reporter, PackageIdentifier.createInDefaultRepo("c/d")));
-
-    // c/d is no longer a subpackage--even though there's a BUILD file in the
-    // second root:
-    try {
-      getPackage("c/d");
-      fail();
-    } catch (NoSuchPackageException e) {
-      assertThat(e).hasMessage(
-          "no such package 'c/d': Package is considered deleted due to --deleted_packages");
-    }
-
-    // Labels in the subpackage are no longer valid...
-    assertLabelValidity(false, "//c/d:x");
-    // ...and now d is just a subdirectory of c:
-    assertLabelValidity(true, "//c:d/x");
-  }
-
-  @Test
-  public void testPackageFeatures() throws Exception {
-    scratch.file("peach/BUILD",
-        "package(features = ['crosstool_default_false'])",
-        "cc_library(name = 'cc', srcs = ['cc.cc'])");
-    Rule cc = (Rule) getTarget("//peach:cc");
-    assertThat(cc.getFeatures()).hasSize(1);
-  }
-
-  /** Visit label and its dependencies and load all of them. */
-  private void visitLabel(String label) throws Exception {
-    TransitivePackageLoader visitor = getPackageManager().newTransitiveLoader();
-    Set<Target> targets = new HashSet<>();
-    targets.add(getPackageManager().getTarget(reporter, Label.parseAbsolute(label)));
-    visitor.sync(reporter, targets, ImmutableSet.<Label>of(),
-        false, 1, Integer.MAX_VALUE);
-  }
-
-  @Test
-  public void testSyntaxErrorInDepPackage() throws Exception {
-    reporter.removeHandler(failFastHandler);
-    AnalysisMock.get().setupMockClient(new MockToolsConfig(rootDirectory));
-
-    scratch.file("a/BUILD",
-        "genrule(name='x',",
-        "        srcs = ['file.txt'],",
-        "        outs = ['foo'],",
-        "        cmd = 'echo')",
-        "@");  // syntax error
-
-    scratch.file("b/BUILD",
-        "genrule(name= 'cc',",
-        "        tools = ['//a:x'],",
-        "        outs = ['bar'],",
-        "        cmd = 'echo')");
-
-    Package pkgB = getPackage("b");
-
-    // We should get error message from package a, but package is properly loaded.
-    visitLabel("//b:cc");
-    assertContainsEvent("invalid character: '@'");
-    assertFalse(pkgB.containsErrors());
-  }
-
-  @Test
-  public void testBrokenPackageOnMultiplePackagePathEntries() throws Exception {
-    reporter.removeHandler(failFastHandler);
-    setOptions("--package_path=.:.");
-    scratch.file("x/y/BUILD");
-    scratch.file("x/BUILD",
-        "genrule(name = 'x',",
-        "srcs = [],",
-        "outs = ['y/z.h'],",
-        "cmd  = '')");
-    Package p = getPackage("x");
-    assertTrue(p.containsErrors());
-  }
-}