aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2018-08-02 10:54:16 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-08-02 10:56:06 -0700
commitee9653458fb11be2ca8c9001c81bdffe6e593ce8 (patch)
tree4ffedefdb242cbf210f17267bb694b7eac71326a
parent0bf578677e7596f88bd37a481f43c3fe7224864a (diff)
Fixed builtins proto. Callable field was not set for functions with no parameter.
RELNOTES: None PiperOrigin-RevId: 207127862
-rw-r--r--src/main/java/com/google/devtools/build/docgen/ApiExporter.java21
1 files changed, 9 insertions, 12 deletions
diff --git a/src/main/java/com/google/devtools/build/docgen/ApiExporter.java b/src/main/java/com/google/devtools/build/docgen/ApiExporter.java
index 993c4d245a..52de905198 100644
--- a/src/main/java/com/google/devtools/build/docgen/ApiExporter.java
+++ b/src/main/java/com/google/devtools/build/docgen/ApiExporter.java
@@ -73,19 +73,16 @@ public class ApiExporter {
Value.Builder field = Value.newBuilder();
field.setName(meth.getName());
field.setDoc(meth.getDocumentation());
- // TODO(andreeabican): Add type string.
- if (!meth.getParams().isEmpty()) {
- Callable.Builder callable = Callable.newBuilder();
- for (SkylarkParamDoc par : meth.getParams()) {
- Param.Builder param = Param.newBuilder();
- param.setName(par.getName());
- param.setType(par.getType());
- param.setDoc(par.getDocumentation());
- callable.addParam(param);
- }
- callable.setReturnType(meth.getReturnType());
- field.setCallable(callable);
+ Callable.Builder callable = Callable.newBuilder();
+ for (SkylarkParamDoc par : meth.getParams()) {
+ Param.Builder param = Param.newBuilder();
+ param.setName(par.getName());
+ param.setType(par.getType());
+ param.setDoc(par.getDocumentation());
+ callable.addParam(param);
}
+ callable.setReturnType(meth.getReturnType());
+ field.setCallable(callable);
return field;
}