aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Damien Martin-Guillerez <dmarting@google.com>2016-01-26 12:11:03 +0000
committerGravatar Lukacs Berki <lberki@google.com>2016-01-26 13:06:45 +0000
commitb88ef8f6af2c804a18e3b38d91bb99b293aaad3f (patch)
treeae00d57da71335ba1e1eef7bce3365fc55b7cbd4
parent96d3b9682e3313c5fdc1e575c22aa286336fb2b2 (diff)
RELNOTES[INC]: Set stamping to false by default (i.e., --nostamp)
Stamping make build non-deterministic and should not be the default. -- MOS_MIGRATED_REVID=113040937
-rw-r--r--src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java2
-rw-r--r--src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java2
2 files changed, 3 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java
index 3f0933032b..cb094c3017 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java
@@ -540,7 +540,7 @@ public final class BuildConfiguration {
public List<Map.Entry<String, String>> pluginCoptList;
@Option(name = "stamp",
- defaultValue = "true",
+ defaultValue = "false",
category = "semantics",
help = "Stamp binaries with the date, username, hostname, workspace information, etc.")
public boolean stampBinaries;
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
index 32f8027723..05a5fbe06d 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
@@ -269,6 +269,8 @@ public abstract class BuildViewTestCase extends FoundationTestCase {
ruleClassProvider.getConfigurationOptions()));
try {
List<String> configurationArgs = new ArrayList<>();
+ // TODO(dmarting): Add --stamp option only to test that requires it.
+ configurationArgs.add("--stamp"); // Stamp is now defaulted to false.
configurationArgs.add("--experimental_extended_sanity_checks");
configurationArgs.addAll(getAnalysisMock().getOptionOverrides());