aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Lukacs Berki <lberki@google.com>2016-07-07 10:57:41 +0000
committerGravatar Klaus Aehlig <aehlig@google.com>2016-07-07 11:19:23 +0000
commitafa04300dd3676c2b295c2e3242f63b738d4abc7 (patch)
tree40dfc1829c85d79af77001631e5efc54e0a5fe17
parent75e387be664d808cd4eae7c9223eeb6789525d79 (diff)
Tweak Win32 process creation settings:
- Use CREATE_NO_WINDOW instead of DETACHED_PROCESS (apparently, that's what we need) - Remove CREATE_BREAKAWAY_FROM_JOB. We now put the Bazel server into its own job that doesn't allow breakaway processes, so it's superfluous. -- MOS_MIGRATED_REVID=126791316
-rw-r--r--src/main/native/windows_processes.cc5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/main/native/windows_processes.cc b/src/main/native/windows_processes.cc
index 13ac3a1f17..f27ba39259 100644
--- a/src/main/native/windows_processes.cc
+++ b/src/main/native/windows_processes.cc
@@ -226,9 +226,8 @@ Java_com_google_devtools_build_lib_windows_WindowsProcesses_nativeCreateProcess(
NULL,
NULL,
TRUE,
- DETACHED_PROCESS
- | CREATE_NEW_PROCESS_GROUP // So that Ctrl-Break does not affect it
- | CREATE_BREAKAWAY_FROM_JOB // We'll put it in a new job
+ CREATE_NO_WINDOW // Don't create a console window
+ | CREATE_NEW_PROCESS_GROUP // So that Ctrl-Break is not propagated
| CREATE_SUSPENDED, // So that it doesn't start a new job itself
env_bytes,
cwd,