Adjust visibility of ComputedDefault dependencies

Also clarify that the returned list is immutable.

--
MOS_MIGRATED_REVID=128482720

1 files changed, 6 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/packages/Attribute.java b/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
index 0655f9f6ec..505211581b 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
@@ -1048,8 +1048,7 @@ public final class Attribute implements Comparable<Attribute> {
    * <p>Implementations of this interface must be immutable.
    */
   public abstract static class ComputedDefault {
-    private final List<String> dependencies;
-    List<String> dependencies() { return dependencies; }
+    private final ImmutableList<String> dependencies;
 
     /**
      * Create a computed default that can read all non-configurable attribute values and no
@@ -1075,6 +1074,11 @@ public final class Attribute implements Comparable<Attribute> {
       dependencies = ImmutableList.of(depAttribute1, depAttribute2);
     }
 
+    /** The list of configurable attributes this ComputedDefault declares it may read. */
+    public ImmutableList<String> dependencies() {
+      return dependencies;
+    }
+
     public abstract Object getDefault(AttributeMap rule);
   }