aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2018-01-18 14:57:38 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-18 14:59:10 -0800
commit80edfd343ba993961c29bc49a60cbc06bb79e8c2 (patch)
tree1126c95774582ec3e3223655eb94ce05c3371dc2
parent33a7cad5c2c82267638cc2ae3081592cef90bc8b (diff)
User can never explicitly set generator_* attributes. So it should be
nonconfigurable. RELNOTES: generator_* attributes are nonconfigurable. PiperOrigin-RevId: 182443578
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/repository/WorkspaceBaseRule.java15
1 files changed, 12 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/repository/WorkspaceBaseRule.java b/src/main/java/com/google/devtools/build/lib/rules/repository/WorkspaceBaseRule.java
index 2130d1a67a..8a6e078e68 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/repository/WorkspaceBaseRule.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/repository/WorkspaceBaseRule.java
@@ -32,9 +32,18 @@ public class WorkspaceBaseRule implements RuleDefinition {
public RuleClass build(Builder builder, RuleDefinitionEnvironment environment) {
return builder
.exemptFromConstraintChecking("workspace rules aren't built for target environments")
- .add(attr("generator_name", STRING).undocumented("internal"))
- .add(attr("generator_function", STRING).undocumented("internal"))
- .add(attr("generator_location", STRING).undocumented("internal"))
+ .add(
+ attr("generator_name", STRING)
+ .undocumented("internal")
+ .nonconfigurable("internal attributes are non-configurable"))
+ .add(
+ attr("generator_function", STRING)
+ .undocumented("internal")
+ .nonconfigurable("internal attributes are non-configurable"))
+ .add(
+ attr("generator_location", STRING)
+ .undocumented("internal")
+ .nonconfigurable("internal attributes are non-configurable"))
.build();
}