aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar jingwen <jingwen@google.com>2018-01-26 07:41:15 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-26 07:42:51 -0800
commit7278db80ca00b44fad4ee593d221f4c570d41354 (patch)
tree64ec5dac484f0876d3d9e8689177b587a8d723fe
parentf049cde7e9165570642eaa1c89a8aa6e5ab1894a (diff)
Added AndroidInstrumentationTestRule to RuleClassProviders.
RELNOTES: None. PiperOrigin-RevId: 183388075
-rw-r--r--src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java6
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java14
2 files changed, 6 insertions, 14 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java
index 76df32e66d..256da1ed6d 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java
+++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java
@@ -80,6 +80,9 @@ import com.google.devtools.build.lib.rules.Alias.AliasRule;
import com.google.devtools.build.lib.rules.android.AarImportBaseRule;
import com.google.devtools.build.lib.rules.android.AndroidConfiguration;
import com.google.devtools.build.lib.rules.android.AndroidDeviceRule;
+import com.google.devtools.build.lib.rules.android.AndroidDeviceScriptFixtureRule;
+import com.google.devtools.build.lib.rules.android.AndroidHostServiceFixtureRule;
+import com.google.devtools.build.lib.rules.android.AndroidInstrumentationTestRule;
import com.google.devtools.build.lib.rules.android.AndroidLibraryBaseRule;
import com.google.devtools.build.lib.rules.android.AndroidLocalTestBaseRule;
import com.google.devtools.build.lib.rules.android.AndroidNeverlinkAspect;
@@ -483,6 +486,9 @@ public class BazelRuleClassProvider {
builder.addRuleDefinition(new AndroidDeviceRule());
builder.addRuleDefinition(new AndroidLocalTestBaseRule());
builder.addRuleDefinition(new BazelAndroidLocalTestRule());
+ builder.addRuleDefinition(new AndroidInstrumentationTestRule());
+ builder.addRuleDefinition(new AndroidDeviceScriptFixtureRule());
+ builder.addRuleDefinition(new AndroidHostServiceFixtureRule());
builder.addSkylarkAccessibleTopLevels("android_common", new AndroidSkylarkCommon());
diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java
index 82a8ecdfbb..5b3c4a6bc0 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidBuildViewTestCase.java
@@ -28,7 +28,6 @@ import com.google.devtools.build.lib.actions.Action;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.CommandLineExpansionException;
import com.google.devtools.build.lib.actions.util.ActionsTestUtil;
-import com.google.devtools.build.lib.analysis.ConfiguredRuleClassProvider;
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
import com.google.devtools.build.lib.analysis.FileProvider;
import com.google.devtools.build.lib.analysis.actions.SpawnAction;
@@ -39,7 +38,6 @@ import com.google.devtools.build.lib.rules.android.deployinfo.AndroidDeployInfoO
import com.google.devtools.build.lib.rules.java.JavaCompileAction;
import com.google.devtools.build.lib.rules.java.JavaInfo;
import com.google.devtools.build.lib.rules.java.JavaRuleOutputJarsProvider;
-import com.google.devtools.build.lib.testutil.TestRuleClassProvider;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
@@ -52,18 +50,6 @@ import javax.annotation.Nullable;
/** Common methods shared between Android related {@link BuildViewTestCase}s. */
public abstract class AndroidBuildViewTestCase extends BuildViewTestCase {
- @Override
- protected ConfiguredRuleClassProvider getRuleClassProvider() {
- ConfiguredRuleClassProvider.Builder builder = new ConfiguredRuleClassProvider.Builder();
- TestRuleClassProvider.addStandardRules(builder);
- return builder
- // TODO(b/35097211): Remove this once the new testing rules are released.
- .addRuleDefinition(new AndroidDeviceScriptFixtureRule())
- .addRuleDefinition(new AndroidHostServiceFixtureRule())
- .addRuleDefinition(new AndroidInstrumentationTestRule())
- .build();
- }
-
protected Iterable<Artifact> getNativeLibrariesInApk(ConfiguredTarget target) {
return Iterables.filter(
getGeneratingAction(getCompressedUnsignedApk(target)).getInputs(),