aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Janak Ramakrishnan <janakr@google.com>2015-02-25 20:28:41 +0000
committerGravatar Han-Wen Nienhuys <hanwen@google.com>2015-02-25 20:28:41 +0000
commit5fe3129b20c5a020bee512f74b3f4054a5a4cda9 (patch)
tree38fa43e006db642907cdad8aa882a6993f4fbcac
parentdffb6ee9dbf19e47b65c50c5f1955014e1e8f68c (diff)
Include NODEP_LABEL in the set of attributes that are not reported as dependencies of a target (along with outputs and NODEP_LABEL_LIST, which was just special because of visibility).
-- MOS_MIGRATED_REVID=87180069
-rw-r--r--src/main/java/com/google/devtools/build/lib/packages/AbstractAttributeMapper.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/AbstractAttributeMapper.java b/src/main/java/com/google/devtools/build/lib/packages/AbstractAttributeMapper.java
index 20b9304fc9..f03ee6bf08 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/AbstractAttributeMapper.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/AbstractAttributeMapper.java
@@ -134,10 +134,10 @@ public abstract class AbstractAttributeMapper implements AttributeMap {
for (Attribute attribute : ruleClass.getAttributes()) {
Type<?> type = attribute.getType();
// TODO(bazel-team): This is incoherent: we shouldn't have to special-case these types
- // for our visitation policy (e.g., why is Type.NODEP_LABEL_LIST excluded but not
- // Type.NODEP_LABEL?). But this is the semantics the calling code requires. Audit
+ // for our visitation policy. But this is the semantics the calling code requires. Audit
// exactly which calling code expects what and clean up this interface.
- if (type == Type.OUTPUT || type == Type.OUTPUT_LIST || type == Type.NODEP_LABEL_LIST) {
+ if (type == Type.OUTPUT || type == Type.OUTPUT_LIST
+ || type == Type.NODEP_LABEL || type == Type.NODEP_LABEL_LIST) {
continue;
}
for (Object value : visitAttribute(attribute.getName(), type)) {