Short-circuit done node dep registration when no new deps

The short-circuiting code was pulled into the !keepGoing conditional
block inadvertently.

RELNOTES: None.
PiperOrigin-RevId: 202505510

1 files changed, 4 insertions, 4 deletions

diff --git a/src/main/java/com/google/devtools/build/skyframe/AbstractParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/AbstractParallelEvaluator.java
index 5381e33bb4..b607e2fa20 100644
--- a/src/main/java/com/google/devtools/build/skyframe/AbstractParallelEvaluator.java
+++ b/src/main/java/com/google/devtools/build/skyframe/AbstractParallelEvaluator.java
@@ -678,15 +678,15 @@ public abstract class AbstractParallelEvaluator {
       SkyFunctionEnvironment env,
       boolean keepGoing)
       throws InterruptedException {
+    Iterator<SkyKey> it = env.getNewlyRequestedDeps().iterator();
+    if (!it.hasNext()) {
+      return;
+    }
 
     // We don't expect any unfinished deps in a keep-going build.
     if (!keepGoing) {
       Map<SkyKey, ? extends NodeEntry> newlyRequestedDepMap =
           graph.getBatch(skyKey, Reason.DONE_CHECKING, env.getNewlyRequestedDeps());
-      Iterator<SkyKey> it = env.getNewlyRequestedDeps().iterator();
-      if (!it.hasNext()) {
-        return;
-      }
       Set<SkyKey> unfinishedDeps = new HashSet<>();
       while (it.hasNext()) {
         SkyKey dep = it.next();