diff options
| author |  pcloudy <pcloudy@google.com> | 2018-04-12 07:28:59 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-04-12 07:30:44 -0700 |
| commit | 4087bc07a6b41f5654b6e968596686369a3433fe (patch) | |
| tree | a37df8e7c4438142f58db64b0df06497174d1a75 | |
| parent | cdacf8451ca9561d22465314e3472d5c90e0d328 (diff) | |
Add document about alwayslink with VS 2017.
RELNOTES: None
PiperOrigin-RevId: 192606955
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCcLibraryRule.java | 4 | ||||
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/rules/cpp/CcImportRule.java | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCcLibraryRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCcLibraryRule.java index ec372b58b0..d28f15dd7e 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCcLibraryRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCcLibraryRule.java @@ -41,6 +41,10 @@ public final class BazelCcLibraryRule implements RuleDefinition { This is useful if your code isn't explicitly called by code in the binary, e.g., if your code registers to receive some callback provided by some service. + + <p>If alwayslink doesn't work with VS 2017 on Windows, that is due to a + [known issue](https://github.com/bazelbuild/bazel/issues/3949), + please upgrade your VS 2017 to the latest version.</p> <!-- #END_BLAZE_RULE.ATTRIBUTE -->*/ .add(attr("alwayslink", BOOLEAN)) .override(attr("linkstatic", BOOLEAN).value(false)) diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcImportRule.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcImportRule.java index 957fe98b0a..deb229dc90 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcImportRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcImportRule.java @@ -89,6 +89,10 @@ public final class CcImportRule implements RuleDefinition { This is useful if your code isn't explicitly called by code in the binary, e.g., if your code registers to receive some callback provided by some service. + + <p>If alwayslink doesn't work with VS 2017 on Windows, that is due to a + [known issue](https://github.com/bazelbuild/bazel/issues/3949), + please upgrade your VS 2017 to the latest version.</p> <!-- #END_BLAZE_RULE.ATTRIBUTE -->*/ .add(attr("alwayslink", BOOLEAN)) .add( |