aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar olaola <olaola@google.com>2017-06-12 19:55:56 +0200
committerGravatar Yun Peng <pcloudy@google.com>2017-06-13 09:38:02 +0200
commit39f7cff73fa00ae3d71857373fdf84f9d969ad72 (patch)
tree6db501ec773155e332db64a3c189a2d90dfea2eb
parent9000e61fc1737444392ffe251727e8331fab3cf2 (diff)
Fix: remote results not downloaded on failed actions, such as interrupted tests.
RELNOTES: none TESTED=presubmit PiperOrigin-RevId: 158734467
-rw-r--r--src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java
index 8807d0652b..383667437d 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java
+++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java
@@ -123,9 +123,7 @@ final class RemoteSpawnRunner implements SpawnRunner {
// TODO(ulfjack): Download stdout, stderr, and the output files in a single call.
passRemoteOutErr(remoteCache, result, policy.getFileOutErr());
- if (result.getExitCode() == 0) {
- remoteCache.downloadAllResults(result, execRoot);
- }
+ remoteCache.downloadAllResults(result, execRoot);
return new SpawnResult.Builder()
.setStatus(Status.SUCCESS) // Even if the action failed with non-zero exit code.
.setExitCode(result.getExitCode())