diff options
author | shahan <shahan@google.com> | 2018-06-29 14:08:49 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-06-29 14:10:13 -0700 |
commit | 38fbbf20419ce76152a1c3d024a5fedfef47403a (patch) | |
tree | 8a4fbde26dcef96d2b175d651295fb3ae8eaa61c | |
parent | 02f480420fc6d786ee7263dadbe9eb8d501f117e (diff) |
Deletes AutoCodec.PUBLIC_FIELDS strategy. Superseded by DynamicCodec.
PiperOrigin-RevId: 202704472
22 files changed, 0 insertions, 104 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java b/src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java index 5025b2c014..ad07a2d736 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java @@ -19,7 +19,6 @@ import com.google.devtools.build.lib.analysis.config.BuildConfiguration; import com.google.devtools.build.lib.analysis.config.BuildConfiguration.LabelListConverter; import com.google.devtools.build.lib.analysis.config.FragmentOptions; import com.google.devtools.build.lib.cmdline.Label; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.common.options.Converters.CommaSeparatedOptionListConverter; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; @@ -27,7 +26,6 @@ import com.google.devtools.common.options.OptionEffectTag; import java.util.List; /** Command-line options for platform-related configuration. */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class PlatformOptions extends FragmentOptions { @Option( name = "host_platform", diff --git a/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java index 2fab7708d1..9e329cebe5 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/ShellConfiguration.java @@ -57,7 +57,6 @@ public class ShellConfiguration extends BuildConfiguration.Fragment { } /** An option that tells Bazel where the shell is. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class Options extends FragmentOptions { @Option( name = "shell_executable", diff --git a/src/main/java/com/google/devtools/build/lib/analysis/WorkspaceStatusAction.java b/src/main/java/com/google/devtools/build/lib/analysis/WorkspaceStatusAction.java index d650252a4c..2baced77ff 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/WorkspaceStatusAction.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/WorkspaceStatusAction.java @@ -22,7 +22,6 @@ import com.google.devtools.build.lib.actions.ActionOwner; import com.google.devtools.build.lib.actions.Artifact; import com.google.devtools.build.lib.actions.ArtifactFactory; import com.google.devtools.build.lib.actions.ArtifactOwner; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.build.lib.util.OptionsUtils; import com.google.devtools.build.lib.vfs.FileSystemUtils; import com.google.devtools.build.lib.vfs.Path; @@ -53,7 +52,6 @@ import java.util.Map; public abstract class WorkspaceStatusAction extends AbstractAction { /** Options controlling the workspace status command. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class Options extends OptionsBase { @Option( name = "embed_label", diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java index faa0891084..bd2d23833b 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java @@ -336,7 +336,6 @@ public class BuildConfiguration implements BuildConfigurationApi { * for semantically identical option values. The simplest way to ensure that is to return the * input string. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class Options extends FragmentOptions implements Cloneable { @Option( name = "experimental_separate_genfiles_directory", diff --git a/src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java index 5456729c20..ea9c9e9281 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/test/TestConfiguration.java @@ -44,7 +44,6 @@ import java.util.Set; @AutoCodec public class TestConfiguration extends Fragment { /** Command-line options. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class TestOptions extends FragmentOptions { @Option( name = "test_filter", diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java index 227920d605..72c40ac956 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProvider.java @@ -91,7 +91,6 @@ import com.google.devtools.build.lib.rules.python.PythonOptions; import com.google.devtools.build.lib.rules.repository.CoreWorkspaceRules; import com.google.devtools.build.lib.rules.repository.NewLocalRepositoryRule; import com.google.devtools.build.lib.rules.test.TestingSupportRules; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.build.lib.skylarkbuildapi.android.AndroidBootstrap; import com.google.devtools.build.lib.util.OS; import com.google.devtools.build.lib.util.ResourceFileLoader; @@ -109,7 +108,6 @@ public class BazelRuleClassProvider { public static final String TOOLS_REPOSITORY = "@bazel_tools"; /** Command-line options. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class StrictActionEnvOptions extends FragmentOptions { @Option( name = "experimental_strict_action_env", diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonConfiguration.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonConfiguration.java index f9c73f0ad5..7193ffafbd 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonConfiguration.java @@ -56,7 +56,6 @@ public class BazelPythonConfiguration extends BuildConfiguration.Fragment { } /** Bazel-specific Python configuration options. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static final class Options extends FragmentOptions { @Option( name = "python2_path", diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java index e5f112064b..810b2cb8a6 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java @@ -275,7 +275,6 @@ public class AndroidConfiguration extends BuildConfiguration.Fragment } /** Android configuration options. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class Options extends FragmentOptions { @Option( name = "Android configuration distinguisher", diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestConfiguration.java index 4158a4bc70..bb35a357de 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestConfiguration.java @@ -23,7 +23,6 @@ import com.google.devtools.build.lib.analysis.config.FragmentOptions; import com.google.devtools.build.lib.analysis.config.InvalidConfigurationException; import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable; import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec.Strategy; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; import com.google.devtools.common.options.OptionEffectTag; @@ -34,7 +33,6 @@ import javax.annotation.Nullable; @Immutable public class AndroidLocalTestConfiguration extends BuildConfiguration.Fragment { /** android_local_test specific options */ - @AutoCodec(strategy = Strategy.PUBLIC_FIELDS) public static final class Options extends FragmentOptions { @Option( name = "experimental_android_local_test_binary_resources", diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java b/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java index 42f6949455..5a2ff9d259 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/apple/AppleCommandLineOptions.java @@ -25,10 +25,8 @@ import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable; import com.google.devtools.build.lib.rules.apple.AppleConfiguration.ConfigurationDistinguisher; import com.google.devtools.build.lib.rules.apple.ApplePlatform.PlatformType; import com.google.devtools.build.lib.skyframe.serialization.DeserializationContext; -import com.google.devtools.build.lib.skyframe.serialization.ObjectCodec; import com.google.devtools.build.lib.skyframe.serialization.SerializationContext; import com.google.devtools.build.lib.skyframe.serialization.SerializationException; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.build.lib.skylarkbuildapi.apple.AppleBitcodeModeApi; import com.google.devtools.build.lib.skylarkinterface.SkylarkPrinter; import com.google.devtools.common.options.Converters.CommaSeparatedOptionListConverter; @@ -43,11 +41,7 @@ import java.io.IOException; import java.util.List; /** Command-line options for building for Apple platforms. */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class AppleCommandLineOptions extends FragmentOptions { - public static final ObjectCodec<AppleCommandLineOptions> CODEC = - new AppleCommandLineOptions_AutoCodec(); - @Option( name = "experimental_apple_mandatory_minimum_version", defaultValue = "false", diff --git a/src/main/java/com/google/devtools/build/lib/rules/apple/swift/SwiftCommandLineOptions.java b/src/main/java/com/google/devtools/build/lib/rules/apple/swift/SwiftCommandLineOptions.java index a623c8634d..8c4e28db49 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/apple/swift/SwiftCommandLineOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/apple/swift/SwiftCommandLineOptions.java @@ -15,14 +15,12 @@ package com.google.devtools.build.lib.rules.apple.swift; import com.google.devtools.build.lib.analysis.config.FragmentOptions; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; import com.google.devtools.common.options.OptionEffectTag; import java.util.List; /** Command-line options for building with Swift tools. */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class SwiftCommandLineOptions extends FragmentOptions { @Option( name = "swiftcopt", diff --git a/src/main/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagOptions.java b/src/main/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagOptions.java index dcbeb01c15..160182003a 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/config/ConfigFeatureFlagOptions.java @@ -18,7 +18,6 @@ import com.google.common.collect.ImmutableSortedMap; import com.google.common.collect.ImmutableSortedSet; import com.google.devtools.build.lib.analysis.config.FragmentOptions; import com.google.devtools.build.lib.cmdline.Label; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.common.options.Converter; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; @@ -29,7 +28,6 @@ import java.util.Optional; import java.util.Set; /** The options fragment which defines {@link ConfigFeatureFlagConfiguration}. */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public final class ConfigFeatureFlagOptions extends FragmentOptions { /** A converter used by the flag options which always returns an empty map, ignoring input. */ public static final class EmptyImmutableSortedMapConverter diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java index c9c05c179c..98d7573aac 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java @@ -25,7 +25,6 @@ import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.cmdline.LabelSyntaxException; import com.google.devtools.build.lib.rules.cpp.CppConfiguration.DynamicMode; import com.google.devtools.build.lib.rules.cpp.CppConfiguration.StripMode; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.build.lib.util.OS; import com.google.devtools.common.options.Converter; import com.google.devtools.common.options.EnumConverter; @@ -41,7 +40,6 @@ import java.util.Map; import java.util.Set; /** Command-line options for C++. */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class CppOptions extends FragmentOptions { /** * Converts a comma-separated list of compilation mode settings to a properly typed List. diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java index 7e15a7e67f..b794bcbc51 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java @@ -26,7 +26,6 @@ import com.google.devtools.build.lib.rules.java.JavaConfiguration.ImportDepsChec import com.google.devtools.build.lib.rules.java.JavaConfiguration.JavaClasspathMode; import com.google.devtools.build.lib.rules.java.JavaConfiguration.JavaOptimizationMode; import com.google.devtools.build.lib.rules.java.JavaConfiguration.OneVersionEnforcementLevel; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.common.options.EnumConverter; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; @@ -39,7 +38,6 @@ import java.util.Map; import java.util.Set; /** Command-line options for building Java targets */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class JavaOptions extends FragmentOptions { /** Converter for the --java_classpath option. */ public static class JavaClasspathModeConverter extends EnumConverter<JavaClasspathMode> { diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcCommandLineOptions.java b/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcCommandLineOptions.java index f9694db412..50cdd61797 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcCommandLineOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/J2ObjcCommandLineOptions.java @@ -17,7 +17,6 @@ package com.google.devtools.build.lib.rules.objc; import com.google.devtools.build.lib.analysis.config.BuildConfiguration.LabelConverter; import com.google.devtools.build.lib.analysis.config.FragmentOptions; import com.google.devtools.build.lib.cmdline.Label; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.common.options.Converters; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; @@ -28,7 +27,6 @@ import java.util.List; * Command-line options for J2ObjC translation of Java source code to ObjC. These command line * options are used by Java rules that can be transpiled (specifically, J2ObjCAspects thereof). */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class J2ObjcCommandLineOptions extends FragmentOptions { @Option( name = "j2objc_translation_flags", diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java index 5766b7d5da..3b1a2c2acd 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcCommandLineOptions.java @@ -19,7 +19,6 @@ import com.google.devtools.build.lib.analysis.config.FragmentOptions; import com.google.devtools.build.lib.cmdline.Label; import com.google.devtools.build.lib.rules.apple.DottedVersion; import com.google.devtools.build.lib.rules.apple.DottedVersionConverter; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.common.options.Converters.CommaSeparatedOptionListConverter; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; @@ -28,7 +27,6 @@ import com.google.devtools.common.options.OptionMetadataTag; import java.util.List; /** Command-line options for building Objective-C targets. */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class ObjcCommandLineOptions extends FragmentOptions { @Option( name = "ios_simulator_version", diff --git a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoConfiguration.java index 353d9038af..3d19e8c7e7 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoConfiguration.java @@ -41,7 +41,6 @@ import java.util.List; // configuration fragment in aspect definitions. public class ProtoConfiguration extends Fragment implements ProtoConfigurationApi { /** Command line options. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class Options extends FragmentOptions { @Option( name = "protocopt", diff --git a/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java b/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java index 7632b776d4..7ace9604af 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java +++ b/src/main/java/com/google/devtools/build/lib/rules/python/PythonOptions.java @@ -14,7 +14,6 @@ package com.google.devtools.build.lib.rules.python; import com.google.devtools.build.lib.analysis.config.FragmentOptions; -import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec; import com.google.devtools.common.options.EnumConverter; import com.google.devtools.common.options.Option; import com.google.devtools.common.options.OptionDocumentationCategory; @@ -22,7 +21,6 @@ import com.google.devtools.common.options.OptionEffectTag; import com.google.devtools.common.options.TriState; /** Python-related command-line options. */ -@AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public class PythonOptions extends FragmentOptions { /** * Converter for the --force_python option. diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodec.java b/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodec.java index 840e7dfaef..fd8635d45f 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodec.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodec.java @@ -64,13 +64,6 @@ public @interface AutoCodec { */ INSTANTIATOR, /** - * Uses the public fields to infer serialization code. - * - * <p>Serializes each public field. Calls the no-arg constructor of the class to instantiate an - * instance for deserialization. - */ - PUBLIC_FIELDS, - /** * For use with {@link com.google.auto.value.AutoValue} classes with an {@link * com.google.auto.value.AutoValue.Builder} static nested Builder class: uses the builder when * deserializing. diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodecProcessor.java b/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodecProcessor.java index 41909261a9..b50681db91 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodecProcessor.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/serialization/autocodec/AutoCodecProcessor.java @@ -108,9 +108,6 @@ public class AutoCodecProcessor extends AbstractProcessor { case INSTANTIATOR: codecClassBuilder = buildClassWithInstantiatorStrategy(encodedType, annotation); break; - case PUBLIC_FIELDS: - codecClassBuilder = buildClassWithPublicFieldsStrategy(encodedType, annotation); - break; case AUTO_VALUE_BUILDER: codecClassBuilder = buildClassWithAutoValueBuilderStrategy(encodedType, annotation); break; @@ -632,45 +629,6 @@ public class AutoCodecProcessor extends AbstractProcessor { return serializeBuilder.build(); } - private TypeSpec.Builder buildClassWithPublicFieldsStrategy( - TypeElement encodedType, AutoCodec annotation) { - TypeSpec.Builder codecClassBuilder = - AutoCodecUtil.initializeCodecClassBuilder(encodedType, env); - ImmutableList<? extends VariableElement> publicFields = - ElementFilter.fieldsIn(env.getElementUtils().getAllMembers(encodedType)) - .stream() - .filter(this::isPublicField) - .collect(toImmutableList()); - codecClassBuilder.addMethod( - buildSerializeMethodWithPublicFields(encodedType, publicFields, annotation)); - MethodSpec.Builder deserializeBuilder = - AutoCodecUtil.initializeDeserializeMethodBuilder(encodedType, env); - buildDeserializeBody(deserializeBuilder, publicFields); - addInstantiatePopulateFieldsAndReturn(deserializeBuilder, encodedType, publicFields); - codecClassBuilder.addMethod(deserializeBuilder.build()); - return codecClassBuilder; - } - - private boolean isPublicField(VariableElement element) { - if (matchesType(element.asType(), Void.class)) { - return false; // Void types can't be instantiated, so the processor ignores them completely. - } - Set<Modifier> modifiers = element.getModifiers(); - return modifiers.contains(Modifier.PUBLIC) && !modifiers.contains(Modifier.STATIC); - } - - private MethodSpec buildSerializeMethodWithPublicFields( - TypeElement encodedType, List<? extends VariableElement> fields, AutoCodec annotation) { - MethodSpec.Builder serializeBuilder = - AutoCodecUtil.initializeSerializeMethodBuilder(encodedType, annotation, env); - for (VariableElement parameter : fields) { - String paramAccessor = "input." + parameter.getSimpleName(); - marshallers.writeSerializationCode( - new Marshaller.Context(serializeBuilder, parameter.asType(), paramAccessor)); - } - return serializeBuilder.build(); - } - /** * Adds a body to the deserialize method that extracts serialized parameters. * @@ -737,24 +695,6 @@ public class AutoCodecProcessor extends AbstractProcessor { } /** - * Invokes the constructor, populates public fields and returns the value. - * - * <p>Used by the {@link AutoCodec.Strategy#PUBLIC_FIELDS} strategy. - */ - private static void addInstantiatePopulateFieldsAndReturn( - MethodSpec.Builder builder, TypeElement type, List<? extends VariableElement> fields) { - builder.addStatement( - "$T deserializationResult = new $T()", - TypeName.get(type.asType()), - TypeName.get(type.asType())); - for (VariableElement field : fields) { - String fieldName = field.getSimpleName().toString(); - builder.addStatement("deserializationResult.$L = $L", fieldName, fieldName + "_"); - } - builder.addStatement("return deserializationResult"); - } - - /** * Adds fields to the codec class to hold offsets and adds a constructor to initialize them. * * <p>For a parameter with name {@code target}, the field will have name {@code target_offset}. diff --git a/src/test/java/com/google/devtools/build/lib/analysis/LateBoundSplitUtil.java b/src/test/java/com/google/devtools/build/lib/analysis/LateBoundSplitUtil.java index 84a70a5d36..c608526eac 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/LateBoundSplitUtil.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/LateBoundSplitUtil.java @@ -39,7 +39,6 @@ import com.google.devtools.common.options.OptionEffectTag; */ public class LateBoundSplitUtil { /** A custom {@link FragmentOptions} with the option to be split. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class TestOptions extends FragmentOptions { // public for options loader @Option( name = "foo", diff --git a/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java b/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java index 00737cb31b..b760ea1803 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java @@ -45,7 +45,6 @@ import org.junit.runners.JUnit4; public class ConfigSettingTest extends BuildViewTestCase { /** Test option that has its null default overridden by its fragment. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class LateBoundTestOptions extends FragmentOptions { public LateBoundTestOptions() {} @@ -84,7 +83,6 @@ public class ConfigSettingTest extends BuildViewTestCase { } /** Test option which is private. */ - @AutoCodec(strategy = AutoCodec.Strategy.PUBLIC_FIELDS) public static class InternalTestOptions extends FragmentOptions { public InternalTestOptions() {} |