aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar cparsons <cparsons@google.com>2018-05-15 14:09:08 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-05-15 14:10:55 -0700
commit374cae61b81e380f0e0c6f2ed84a8fbae4da1d7f (patch)
treed749df8ff5d7b32e1232dbf65ede8ce43e4157a3
parente54859e5aad69c1b05c3460d8083e9b4736ae3ed (diff)
Migrate Aspect to skylarkbuildapi
RELNOTES: None. PiperOrigin-RevId: 196726540
-rw-r--r--src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java10
-rw-r--r--src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkAspectApi.java14
2 files changed, 11 insertions, 13 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java b/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java
index a39d69db5e..473df9138b 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/SkylarkAspect.java
@@ -17,19 +17,9 @@ package com.google.devtools.build.lib.packages;
import com.google.common.collect.ImmutableSet;
import com.google.devtools.build.lib.events.Location;
import com.google.devtools.build.lib.skylarkbuildapi.SkylarkAspectApi;
-import com.google.devtools.build.lib.skylarkinterface.SkylarkModule;
-import com.google.devtools.build.lib.skylarkinterface.SkylarkModuleCategory;
import com.google.devtools.build.lib.syntax.EvalException;
/** Represents an aspect which can be attached to a skylark-defined rule attribute. */
-@SkylarkModule(
- name = "Aspect",
- category = SkylarkModuleCategory.NONE,
- doc =
- "For more information about Aspects, please consult the <a href=\"globals.html#aspect\">"
- + "documentation of the aspect function</a> or the "
- + "<a href=\"../aspects.md\">introduction to Aspects</a>."
-)
public interface SkylarkAspect extends SkylarkAspectApi {
/**
diff --git a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkAspectApi.java b/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkAspectApi.java
index 30e4127c3b..44f1ea4196 100644
--- a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkAspectApi.java
+++ b/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/SkylarkAspectApi.java
@@ -14,9 +14,17 @@
package com.google.devtools.build.lib.skylarkbuildapi;
+import com.google.devtools.build.lib.skylarkinterface.SkylarkModule;
+import com.google.devtools.build.lib.skylarkinterface.SkylarkModuleCategory;
import com.google.devtools.build.lib.skylarkinterface.SkylarkValue;
/** The interface for skylark-defined aspects in the Build API. */
-public interface SkylarkAspectApi extends SkylarkValue {
- // TODO(cparsons): Migrate this API from the Bazel-specific implementation.
-}
+@SkylarkModule(
+ name = "Aspect",
+ category = SkylarkModuleCategory.NONE,
+ doc =
+ "For more information about Aspects, please consult the <a href=\"globals.html#aspect\">"
+ + "documentation of the aspect function</a> or the "
+ + "<a href=\"../aspects.md\">introduction to Aspects</a>."
+)
+public interface SkylarkAspectApi extends SkylarkValue {}