diff options
author | twerth <twerth@google.com> | 2018-07-09 08:40:24 -0700 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-07-09 08:41:53 -0700 |
commit | 2f0033a6a314da8bf22eed6e08ef9d7cbb5d8ff1 (patch) | |
tree | bd0f7aa062ed6029a5d2a6efee3639a701dee294 | |
parent | 8cc62f781ff4e724f8c2f763487390063fcc79e4 (diff) |
Add more profiling information to better understand what's happening in analysis phase.
RELNOTES: None
PiperOrigin-RevId: 203771085
-rw-r--r-- | src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java index c41bf5d224..93379b780f 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeBuildView.java @@ -65,6 +65,8 @@ import com.google.devtools.build.lib.packages.NoSuchTargetException; import com.google.devtools.build.lib.packages.Package; import com.google.devtools.build.lib.packages.Target; import com.google.devtools.build.lib.pkgcache.LoadingFailureEvent; +import com.google.devtools.build.lib.profiler.Profiler; +import com.google.devtools.build.lib.profiler.SilentCloseable; import com.google.devtools.build.lib.skyframe.AspectFunction.AspectCreationException; import com.google.devtools.build.lib.skyframe.AspectValue.AspectValueKey; import com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.ConfiguredValueCreationException; @@ -255,15 +257,18 @@ public final class SkyframeBuildView { throws InterruptedException, ViewCreationFailedException { enableAnalysis(true); EvaluationResult<ActionLookupValue> result; - try { + try (SilentCloseable c = Profiler.instance().profile("skyframeExecutor.configureTargets")) { result = skyframeExecutor.configureTargets( eventHandler, values, aspectKeys, keepGoing, numThreads); } finally { enableAnalysis(false); } - ImmutableMap<ActionAnalysisMetadata, ConflictException> badActions = - skyframeExecutor.findArtifactConflicts(); + ImmutableMap<ActionAnalysisMetadata, ConflictException> badActions; + try (SilentCloseable c = + Profiler.instance().profile("skyframeExecutor.findArtifactConflicts")) { + badActions = skyframeExecutor.findArtifactConflicts(); + } Collection<AspectValue> goodAspects = Lists.newArrayListWithCapacity(values.size()); Root singleSourceRoot = skyframeExecutor.getForcedSingleSourceRootIfNoExecrootSymlinkCreation(); |