diff options
| author |  laszlocsomor <laszlocsomor@google.com> | 2017-07-25 14:36:01 +0200 |
|---|---|---|
| committer |  Jakob Buchgraber <buchgr@google.com> | 2017-07-26 10:34:41 +0200 |
| commit | 2aabbeb96113b7bf44d3f12e8e9a7aa9c22e9469 (patch) | |
| tree | 5c75987a5da110e87b1d83f83d19785485ae3996 | |
| parent | 7a9ec4d2781442f0aaac11497f79210fb9027208 (diff) | |
expunge_async: add comment about MacOS feasibility
Fixes https://github.com/bazelbuild/bazel/issues/1906
RELNOTES: none
PiperOrigin-RevId: 163059900
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java b/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java index a071a25db2..f908039dca 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java @@ -152,6 +152,9 @@ public final class CleanCommand implements BlazeCommand { // TODO(dmarting): Deactivate expunge_async on non-Linux platform until we completely fix it // for non-Linux platforms (https://github.com/bazelbuild/bazel/issues/1906). + // MacOS and FreeBSD support setsid(2) but don't have /usr/bin/setsid, so if we wanted to + // support --expunge_async on these platforms, we'd have to write a wrapper that calls setsid(2) + // and exec(2). if ((expungeAsync || async) && OS.getCurrent() != OS.LINUX) { String fallbackName = expungeAsync ? "--expunge" : "synchronous clean"; env.getReporter() |