diff options
author | 2016-05-02 11:44:49 +0000 | |
---|---|---|
committer | 2016-05-02 11:52:03 +0000 | |
commit | 29c4a950228a11201667c947f9843644e6a43145 (patch) | |
tree | 399373f7dadf3e72be021f0b7ebaca53f8ab4abc | |
parent | cab6e87d8e388a4c5be61dbefc11c13cbdbe65de (diff) |
Remove wrong test in rc_options_test
The test_terminal_columns_default as part of the rc-options test incorrectly
assumed that (in the standard UI) the default width for terminal columns should
be long enough to not need line wrapping, even for a 32 character long
label. However, the default value is 80, and another 37 characters quickly come
together: 8 for the progress information ("[3 / 4] "), 23 for the activity
("Creating runfiles tree "), and, depending on the actual build, another couple
of characters for the the path fragment (like "bazel-out/local_linux-fastbuild",
which has 31 characters on its own). So remove that test based on wrong assumptions.
--
Change-Id: I6019f8d30e774ade0340bcec8f7ddb3768068135
Reviewed-on: https://bazel-review.googlesource.com/#/c/3541
MOS_MIGRATED_REVID=121262554
-rwxr-xr-x | src/test/shell/integration/rc_options_test.sh | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/test/shell/integration/rc_options_test.sh b/src/test/shell/integration/rc_options_test.sh index e34914175d..df9cb80f67 100755 --- a/src/test/shell/integration/rc_options_test.sh +++ b/src/test/shell/integration/rc_options_test.sh @@ -70,13 +70,4 @@ EOF expect_not_log '^xxxxxxxxxxx' } -function test_terminal_columns_default() { - setup_bazelrc - bazel test --curses=yes --color=yes pkg:xxxxxxxxxxxxxxxxxxxxxxxxxtrue \ - 2>$TEST_log || fail "bazel test failed" - # default terminal columns should be large enough to not wrap - # this short example - expect_not_log '^xxx' -} - run_suite "Integration tests for rc options handling" |