More precisely document AttributeMap.get (particularly the possibility

of null values).

--
MOS_MIGRATED_REVID=89443545

1 files changed, 7 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/packages/AttributeMap.java b/src/main/java/com/google/devtools/build/lib/packages/AttributeMap.java
index 131ed05972..e389539450 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/AttributeMap.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/AttributeMap.java
@@ -39,9 +39,14 @@ public interface AttributeMap {
   Label getLabel();
 
   /**
-   * Returns the value of the named rule attribute, which must be of the given type. If it does not
-   * exist or has the wrong type, throws an {@link IllegalArgumentException}.
+   * Returns the value of the named rule attribute, which must be of the given type. This may
+   * be null (for example, for an attribute with no default value that isn't explicitly set in
+   * the rule - see {@link Type#getDefaultValue}).
+   *
+   * <p>If the rule doesn't have this attribute with the specified type, throws an
+   * {@link IllegalArgumentException}.
    */
+  @Nullable
   <T> T get(String attributeName, Type<T> type);
 
   /**