aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar cushon <cushon@google.com>2018-01-10 11:55:47 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-01-10 11:58:14 -0800
commit22ccdd1ebe1dc495e05d894a3325f6b05e681fb3 (patch)
treecabd318433c45a52a192d4d1b35489e50c788b89
parentf6ca78808722c8c119affdb33400838ee92d44b6 (diff)
Fix turbine command lines with empty javacopts
See #4422 PiperOrigin-RevId: 181497117
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java
index 933d69b36d..6cffa7b35a 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileAction.java
@@ -549,9 +549,11 @@ public class JavaHeaderCompileAction extends SpawnAction {
result.addExecPaths("--source_jars", ImmutableList.copyOf(sourceJars));
}
- result.addAll("--javacopts", javacOpts);
- // terminate --javacopts with `--` to support javac flags that start with `--`
- result.add("--");
+ if (!javacOpts.isEmpty()) {
+ result.addAll("--javacopts", javacOpts);
+ // terminate --javacopts with `--` to support javac flags that start with `--`
+ result.add("--");
+ }
if (ruleKind != null) {
result.add("--rule_kind", ruleKind);