diff options
author | 2017-02-23 22:49:38 +0000 | |
---|---|---|
committer | 2017-02-24 08:30:55 +0000 | |
commit | 1dfddb22cee1cfd736227243a10c8c2127151134 (patch) | |
tree | 7ebe64fc4aeb4e53157be611fa25719f7f6b69aa | |
parent | 0cc293e46771144837a5ad4accf5d49e655060e9 (diff) |
Expose proto_library, java_lite_proto_library, java_proto_library and cc_proto_library to the outside world.
RELNOTES: New rules in Bazel: proto_library, java_lite_proto_library, java_proto_library and cc_proto_library
--
PiperOrigin-RevId: 148394617
MOS_MIGRATED_REVID=148394617
4 files changed, 1 insertions, 11 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoLibraryRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoLibraryRule.java index fe814609cc..5969c7aa5b 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoLibraryRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoLibraryRule.java @@ -61,8 +61,6 @@ public class BazelJavaLiteProtoLibraryRule implements RuleDefinition { @Override public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment environment) { return builder - // This rule isn't ready for use yet. - .setUndocumented() .requiresConfigurationFragments(JavaConfiguration.class) /* <!-- #BLAZE_RULE(java_lite_proto_library).ATTRIBUTE(deps) --> The list of <a href="protocol-buffer.html#proto_library"><code>proto_library</code></a> diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java index 30abfb3301..8c4ed4b81f 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaProtoLibraryRule.java @@ -54,8 +54,6 @@ public class BazelJavaProtoLibraryRule implements RuleDefinition { @Override public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment environment) { return builder - // This rule isn't ready for use yet. - .setUndocumented() .requiresConfigurationFragments(JavaConfiguration.class) /* <!-- #BLAZE_RULE(java_proto_library).ATTRIBUTE(deps) --> The list of <a href="protocol-buffer.html#proto_library"><code>proto_library</code></a> diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/proto/CcProtoLibraryRule.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/proto/CcProtoLibraryRule.java index f41b49c24a..065f722565 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/proto/CcProtoLibraryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/proto/CcProtoLibraryRule.java @@ -50,8 +50,6 @@ public class CcProtoLibraryRule implements RuleDefinition { @Override public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment environment) { return builder - // This rule isn't ready for use yet. - .setUndocumented() /* <!-- #BLAZE_RULE(cc_proto_library).ATTRIBUTE(deps) --> The list of <a href="protocol-buffer.html#proto_library"><code>proto_library</code></a> rules to generate C++ code for. diff --git a/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java b/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java index 9474c9401f..cbb09fd149 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java +++ b/src/main/java/com/google/devtools/build/lib/rules/proto/BazelProtoLibraryRule.java @@ -52,10 +52,6 @@ public final class BazelProtoLibraryRule implements RuleDefinition { return builder .requiresConfigurationFragments(ProtoConfiguration.class) - // This rule works, but does nothing, in open-source Bazel, due to the - // lack of protoc support. Users can theoretically write their own Skylark rules, - // but these are still 'experimental' according to the documentation. - .setUndocumented() .setOutputToGenfiles() .add(attr(":proto_compiler", LABEL).cfg(HOST).exec().value(PROTO_COMPILER)) /* <!-- #BLAZE_RULE(proto_library).ATTRIBUTE(deps) --> @@ -95,7 +91,7 @@ public final class BazelProtoLibraryRule implements RuleDefinition { <p>Use <code>proto_library</code> to define libraries of protocol buffers which may be used from multiple languages. A <code>proto_library</code> may be listed - in the <code>deps</code> clause of supported rules, such as <code>objc_proto_library</code>. + in the <code>deps</code> clause of supported rules, such as <code>java_proto_library</code>. </p> <!-- #END_BLAZE_RULE -->*/ |