aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2018-08-02 08:19:50 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-08-02 08:21:21 -0700
commit1a5067a294393ee34ed11c23e67207852e787095 (patch)
tree98cf10a7778712b5b17863fe8b032cc582a6c155
parent237a57ae388788b1695020f50a258a678e2cbd16 (diff)
Excluded "self" param from the callable symbols. In .bzl files it is not used in the function call.
RELNOTES: None PiperOrigin-RevId: 207102812
-rw-r--r--src/main/java/com/google/devtools/build/docgen/skylark/SkylarkBuiltinMethodDoc.java2
-rw-r--r--src/main/java/com/google/devtools/build/docgen/skylark/SkylarkConstructorMethodDoc.java5
-rw-r--r--src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java5
3 files changed, 9 insertions, 3 deletions
diff --git a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkBuiltinMethodDoc.java b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkBuiltinMethodDoc.java
index 4a2c5f8bad..396b3b0989 100644
--- a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkBuiltinMethodDoc.java
+++ b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkBuiltinMethodDoc.java
@@ -34,7 +34,7 @@ public final class SkylarkBuiltinMethodDoc extends SkylarkMethodDoc {
this.params =
SkylarkDocUtils.determineParams(
this,
- annotation.parameters(),
+ withoutSelfParam(annotation),
annotation.extraPositionals(),
annotation.extraKeywords());
}
diff --git a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkConstructorMethodDoc.java b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkConstructorMethodDoc.java
index c2491913c7..44cde7340e 100644
--- a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkConstructorMethodDoc.java
+++ b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkConstructorMethodDoc.java
@@ -36,7 +36,10 @@ public final class SkylarkConstructorMethodDoc extends SkylarkMethodDoc {
this.callable = callable;
this.params =
SkylarkDocUtils.determineParams(
- this, callable.parameters(), callable.extraPositionals(), callable.extraKeywords());
+ this,
+ withoutSelfParam(callable, method),
+ callable.extraPositionals(),
+ callable.extraKeywords());
}
public Method getMethod() {
diff --git a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java
index eeff9fa73e..24524eba62 100644
--- a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java
+++ b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkJavaMethodDoc.java
@@ -40,7 +40,10 @@ public final class SkylarkJavaMethodDoc extends SkylarkMethodDoc {
this.callable = callable;
this.params =
SkylarkDocUtils.determineParams(
- this, callable.parameters(), callable.extraPositionals(), callable.extraKeywords());
+ this,
+ withoutSelfParam(callable, method),
+ callable.extraPositionals(),
+ callable.extraKeywords());
}
public Method getMethod() {