Ignore garbage when packet len > message len

From -c shadow on 15-Nov-2011, discussing a problem where some notices
received from other realms were causing clients to crash:

So, the packet that crashed my client had extra garbage beyond what
should have been the end of the packet.  So z_multinotice was 0/61,
but the packet was longer than 61.  Which means the logic that should
have treated this as an unfragmented notice (because partof ==
z_message_len) did not trigger.

So a holelist gets created, with enough storage for partof, and then
Z_AddNoticeToEntry is called to copy z_message_len (> partof) bytes
into it.

So, I don't know why your client, or the server, or something, is sending
packets longer than the message length, but I don't think I actually want
to just discard those, because then "legitimate" messages would vanish.

Instead, if part + notice->z_message_len > partof, I just want to ignore
the extra.

0 files changed, 0 insertions, 0 deletions