aboutsummaryrefslogtreecommitdiffhomepage
path: root/modules
diff options
context:
space:
mode:
authorGravatar mitchell <70453897+orbitalquark@users.noreply.github.com>2021-04-12 01:50:22 -0400
committerGravatar mitchell <70453897+orbitalquark@users.noreply.github.com>2021-04-12 01:50:22 -0400
commit19899b518f18165b1dfb6d9b4b18e531f4b56249 (patch)
treeb6a5356b0453be53826d29947cb8b7221d37f796 /modules
parente17757efbd4d67901abb7cb165d93c76bdca2d8c (diff)
Fixed a bug where redoing a full-buffer change could jump to an unrelated state.
Do a simple position save instead of using the history mechanism.
Diffstat (limited to 'modules')
-rw-r--r--modules/textadept/history.lua11
1 files changed, 6 insertions, 5 deletions
diff --git a/modules/textadept/history.lua b/modules/textadept/history.lua
index 05081ddd..8c784c17 100644
--- a/modules/textadept/history.lua
+++ b/modules/textadept/history.lua
@@ -33,14 +33,14 @@ local view_history = setmetatable({}, {
end
})
-local restore_position, first_visible_line = false, nil
+local restore_position, pos, first_visible_line = false, nil, nil
-- Restore position after a full-buffer undo/redo operation, e.g. after replacing buffer contents
-- with a formatting command and then performing an undo.
events.connect(events.UPDATE_UI, function(updated)
if not restore_position or updated & buffer.UPDATE_SELECTION == 0 then return end
restore_position = false
- M.back()
- view.first_visible_line, first_visible_line = first_visible_line, nil
+ buffer:goto_pos(pos)
+ view.first_visible_line, pos, first_visible_line = first_visible_line, nil, nil
end)
-- Listens for text insertion and deletion events and records their locations.
@@ -56,8 +56,9 @@ events.connect(events.MODIFIED, function(position, mod, text, length)
elseif mod & buffer.MOD_DELETETEXT > 0 then
if buffer.length == 0 then return end -- ignore replacing buffer contents
elseif mod & (buffer.PERFORMED_UNDO | buffer.PERFORMED_REDO) > 0 and
- (mod & buffer.MOD_BEFOREDELETE > 0) and length == buffer.length then
- first_visible_line = view.first_visible_line -- save for potential undo before it's lost
+ (mod & buffer.MOD_BEFOREDELETE > 0) and length == buffer.length then
+ -- Save view state for potential undo before it's lost.
+ pos, first_visible_line = buffer.current_pos, view.first_visible_line
else
return
end