aboutsummaryrefslogtreecommitdiffhomepage
path: root/doc
diff options
context:
space:
mode:
authorGravatar mitchell <70453897+667e-11@users.noreply.github.com>2020-03-30 18:44:15 -0400
committerGravatar mitchell <70453897+667e-11@users.noreply.github.com>2020-03-30 18:44:15 -0400
commitc46527cc32aef6fd332ea5e45757c0858b1cbb5d (patch)
tree8ffd94daf08117a21469697c4cec2c14a5bfdeb3 /doc
parent4d88d116f8f8181186fd734841d5303269924c16 (diff)
Fixed off-by-one issues with `buffer:get_cur_line()`.
Diffstat (limited to 'doc')
-rw-r--r--doc/manual.md4
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/manual.md b/doc/manual.md
index 2779713d..880e3313 100644
--- a/doc/manual.md
+++ b/doc/manual.md
@@ -2080,6 +2080,10 @@ In migrating Textadept's internals, the following changes were made:
* Marker or indicator masks are produced by subtracting 1 from marker or
indicator numbers. For example, `1 << textadept.bookmarks.MARK_BOOKMARK`
changes to `1 << textadept.bookmarks.MARK_BOOKMARK - 1`.
+* Logic that depends on the return value of `buffer:get_cur_line()` may need to
+ be changed. For example, any subsequent references to `pos` after
+ `local line, pos = buffer:get_cur_line()` like `if line:sub(1, pos) ... end`
+ need to be changed to `if line:sub(1, pos - 1) ... end`.
I found it helpful to quickly scan source files for syntax-highlighted numbers
and then seeing if those numbers needed to be changed. Searching for "- 1",