1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
/* Copyright 2018 The TensorFlow Authors. All Rights Reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/
#include "tensorflow/core/distributed_runtime/device_resolver_distributed.h"
#include "tensorflow/core/common_runtime/device_mgr.h"
#include "tensorflow/core/distributed_runtime/test_utils.h"
#include "tensorflow/core/lib/core/notification.h"
#include "tensorflow/core/lib/core/status_test_util.h"
#include "tensorflow/core/lib/strings/strcat.h"
#include "tensorflow/core/platform/logging.h"
#include "tensorflow/core/platform/test.h"
#include "tensorflow/core/util/device_name_utils.h"
namespace tensorflow {
namespace {
// Subclass of DeviceResolverDistributed which behaves identically but
// allows access to the attr_table_.
class TestableDeviceResolverDistributed : public DeviceResolverDistributed {
public:
TestableDeviceResolverDistributed(const DeviceMgr* dev_mgr,
WorkerCacheInterface* worker_cache,
const string& task)
: DeviceResolverDistributed(dev_mgr, worker_cache, task) {}
gtl::FlatMap<string, DeviceAttributes>& attr_table() { return attr_table_; }
};
// Create a fake 'Device' whose only interesting attribute is a non-default
// DeviceLocality.
static Device* NewDevice(const string& type, const string& name,
int numa_node) {
class FakeDevice : public Device {
public:
explicit FakeDevice(const DeviceAttributes& attr) : Device(nullptr, attr) {}
Status Sync() override { return Status::OK(); }
Allocator* GetAllocator(AllocatorAttributes) override { return nullptr; }
};
DeviceAttributes attr;
attr.set_name(name);
attr.set_device_type(type);
attr.mutable_locality()->set_numa_node(numa_node);
return new FakeDevice(attr);
}
// Create a fake WorkerInterface that responds to requests without RPCs,
// in this case returning the DeviceAttributes of a fake remote worker.
class FakeWorker : public TestWorkerInterface {
public:
FakeWorker(const string& name, DeviceMgr* dev_mgr,
DeviceResolverDistributed* dres)
: name_(name), device_mgr_(dev_mgr), device_resolver_(dres) {}
void GetStatusAsync(const GetStatusRequest* request,
GetStatusResponse* response,
StatusCallback done) override {
std::vector<DeviceAttributes> dev_attr;
device_mgr_->ListDeviceAttributes(&dev_attr);
for (const auto& da : dev_attr) {
*response->add_device_attributes() = da;
}
done(Status::OK());
}
private:
string name_;
DeviceMgr* device_mgr_;
DeviceResolverDistributed* device_resolver_;
};
// An implementation of WorkerCacheInterface that routes all requests
// to local FakeWorkers, implementing only the methods needed for tests.
class FakeCache : public TestWorkerCache {
public:
// Override the Locality methods to actually pass through to the
// worker.
bool GetDeviceLocalityNonBlocking(const string& device,
DeviceLocality* locality) override {
return false;
}
void GetDeviceLocalityAsync(const string& device, DeviceLocality* locality,
StatusCallback done) override {
string task_name;
string dev_part;
if (!DeviceNameUtils::SplitDeviceName(device, &task_name, &dev_part)) {
done(errors::Internal("failed to parse device name"));
return;
}
auto it = workers_.find(task_name);
if (it == workers_.end()) {
done(errors::Internal("failed to find worker ", task_name));
return;
}
WorkerInterface* wi = it->second;
GetStatusRequest req;
GetStatusResponse resp;
Notification note;
Status status = wi->GetStatus(&req, &resp);
if (!status.ok()) {
done(status);
return;
}
for (const auto& it : resp.device_attributes()) {
if (it.name() == device) {
*locality = it.locality();
done(Status::OK());
return;
}
}
done(errors::Internal("device not found: ", device));
}
};
class DeviceResDistTest : public ::testing::Test {
protected:
DeviceResDistTest() {}
~DeviceResDistTest() override {
for (DeviceMgr* dm : device_mgrs_) {
delete dm;
}
for (auto it : resolvers_) {
delete it.second;
}
for (FakeWorker* w : workers_) {
delete w;
}
}
void DefineWorkers(int num_workers, int num_devices,
const string& device_type) {
for (int w = 0; w < num_workers; ++w) {
string name = strings::StrCat("/job:worker/replica:0/task:", w);
DefineWorker(name, device_type, num_devices);
}
}
void DefineWorker(const string& worker_name, const string& device_type,
int num_devices) {
std::vector<Device*> devices;
for (int i = 0; i < num_devices; ++i) {
devices.push_back(NewDevice(
device_type,
strings::StrCat(worker_name, "/device:", device_type, ":", i), i));
}
DeviceMgr* dev_mgr = new DeviceMgr(devices);
TestableDeviceResolverDistributed* dev_res =
new TestableDeviceResolverDistributed(dev_mgr, &wc_, worker_name);
resolvers_[worker_name] = dev_res;
device_mgrs_.push_back(dev_mgr);
std::vector<string>* dv = &dev_by_task_[worker_name];
for (auto d : devices) {
dv->push_back(d->name());
}
FakeWorker* fw = new FakeWorker(worker_name, dev_mgr, dev_res);
workers_.push_back(fw);
wc_.AddWorker(worker_name, fw);
}
FakeCache wc_;
std::vector<DeviceMgr*> device_mgrs_;
std::unordered_map<string, TestableDeviceResolverDistributed*> resolvers_;
std::unordered_map<string, std::vector<string>> dev_by_task_;
std::vector<FakeWorker*> workers_;
};
TEST_F(DeviceResDistTest, Workers3Devices4) {
DefineWorkers(3, 4, "CPU");
// Check that every device is available from every task.
for (auto it : resolvers_) {
DeviceResolverDistributed* dres = it.second;
for (auto it2 : dev_by_task_) {
const string& task_name = it2.first;
for (const auto& dev_name : it2.second) {
DeviceNameUtils::ParsedName parsed;
ASSERT_TRUE(DeviceNameUtils::ParseFullName(dev_name, &parsed));
Notification note;
Status status;
DeviceLocality locality;
dres->GetLocalityAsync(dev_name, task_name, &locality,
[this, ¬e, &status](const Status& s) {
status = s;
note.Notify();
});
note.WaitForNotification();
TF_EXPECT_OK(status);
EXPECT_EQ(parsed.id, locality.numa_node());
}
}
}
// Clear just task 0 from all.
const string w0_name = "/job:worker/replica:0/task:0";
for (auto it : resolvers_) {
if (it.first == w0_name) continue;
TestableDeviceResolverDistributed* dres = it.second;
EXPECT_EQ(8, it.second->attr_table().size());
dres->ClearTask("/job:worker/replica:0/task:0");
EXPECT_EQ(4, it.second->attr_table().size());
}
}
} // namespace
} // namespace tensorflow
|
