aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
diff options
context:
space:
mode:
Diffstat (limited to 'tensorflow/tools/tfprof/internal/advisor/operation_checker.h')
-rw-r--r--tensorflow/tools/tfprof/internal/advisor/operation_checker.h19
1 files changed, 10 insertions, 9 deletions
diff --git a/tensorflow/tools/tfprof/internal/advisor/operation_checker.h b/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
index 4d0d68e3bf..2a05f9bfd0 100644
--- a/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
+++ b/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
@@ -24,11 +24,10 @@ namespace tfprof {
class OperationChecker : public Checker {
public:
- string name() const override { return kCheckers[1]; }
+ string name() override { return "OperationChecker"; }
private:
- AdviceProto::Checker Check(const AdvisorOptionsProto::CheckerOption& options,
- const TFStats* stats) override {
+ std::vector<string> Check(const TFStats* stats) override {
if (!stats) {
fprintf(stderr, "Missing profiles (e.g. graph, run_meta). Skip %s\n",
name().c_str());
@@ -54,20 +53,22 @@ class OperationChecker : public Checker {
}
}
if (use_batch_norm && !use_fused_batch_norm) {
- reports_.add_reports(
- "Maybe use faster FusedBatchNorm instead of BatchNorm");
+ reports_.push_back(strings::Printf(
+ "%s: Maybe use faster FusedBatchNorm instead of BatchNorm",
+ kLevel[1]));
}
if (recommend_nchw) {
// TODO(xpan): Maybe print which Op supports NCHW.
- reports_.add_reports(
- "Found operation using NHWC data_format on GPU. Maybe "
- "NCHW is faster.");
+ reports_.push_back(strings::Printf(
+ "%s: Found operation using NHWC data_format on GPU. Maybe "
+ "NCHW is faster.",
+ kLevel[1]));
}
return reports_;
}
private:
- AdviceProto::Checker reports_;
+ std::vector<string> reports_;
};
} // namespace tfprof