aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
diff options
context:
space:
mode:
Diffstat (limited to 'tensorflow/tools/tfprof/internal/advisor/operation_checker.h')
-rw-r--r--tensorflow/tools/tfprof/internal/advisor/operation_checker.h19
1 files changed, 9 insertions, 10 deletions
diff --git a/tensorflow/tools/tfprof/internal/advisor/operation_checker.h b/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
index 2a05f9bfd0..4d0d68e3bf 100644
--- a/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
+++ b/tensorflow/tools/tfprof/internal/advisor/operation_checker.h
@@ -24,10 +24,11 @@ namespace tfprof {
class OperationChecker : public Checker {
public:
- string name() override { return "OperationChecker"; }
+ string name() const override { return kCheckers[1]; }
private:
- std::vector<string> Check(const TFStats* stats) override {
+ AdviceProto::Checker Check(const AdvisorOptionsProto::CheckerOption& options,
+ const TFStats* stats) override {
if (!stats) {
fprintf(stderr, "Missing profiles (e.g. graph, run_meta). Skip %s\n",
name().c_str());
@@ -53,22 +54,20 @@ class OperationChecker : public Checker {
}
}
if (use_batch_norm && !use_fused_batch_norm) {
- reports_.push_back(strings::Printf(
- "%s: Maybe use faster FusedBatchNorm instead of BatchNorm",
- kLevel[1]));
+ reports_.add_reports(
+ "Maybe use faster FusedBatchNorm instead of BatchNorm");
}
if (recommend_nchw) {
// TODO(xpan): Maybe print which Op supports NCHW.
- reports_.push_back(strings::Printf(
- "%s: Found operation using NHWC data_format on GPU. Maybe "
- "NCHW is faster.",
- kLevel[1]));
+ reports_.add_reports(
+ "Found operation using NHWC data_format on GPU. Maybe "
+ "NCHW is faster.");
}
return reports_;
}
private:
- std::vector<string> reports_;
+ AdviceProto::Checker reports_;
};
} // namespace tfprof