diff options
-rw-r--r-- | tensorflow/tensorboard/components/tf-graph-common/lib/parser.ts | 2 | ||||
-rw-r--r-- | tensorflow/tensorboard/components/tf-graph-common/test/parser-test.ts | 30 |
2 files changed, 22 insertions, 10 deletions
diff --git a/tensorflow/tensorboard/components/tf-graph-common/lib/parser.ts b/tensorflow/tensorboard/components/tf-graph-common/lib/parser.ts index b49b7650e6..5611ff0708 100644 --- a/tensorflow/tensorboard/components/tf-graph-common/lib/parser.ts +++ b/tensorflow/tensorboard/components/tf-graph-common/lib/parser.ts @@ -27,7 +27,7 @@ function parseValue(value: string): string|number|boolean { return false; } let firstChar = value[0]; - if (firstChar === '\'') { + if (firstChar === '"') { return value.substring(1, value.length - 1); } let num = parseFloat(value); diff --git a/tensorflow/tensorboard/components/tf-graph-common/test/parser-test.ts b/tensorflow/tensorboard/components/tf-graph-common/test/parser-test.ts index 59f5e8594f..5cefbb5d88 100644 --- a/tensorflow/tensorboard/components/tf-graph-common/test/parser-test.ts +++ b/tensorflow/tensorboard/components/tf-graph-common/test/parser-test.ts @@ -18,27 +18,39 @@ suite('parser', () => { test('simple pbtxt', (done) => { let pbtxt = `node { - name: 'Q' - op: 'Input' + name: "Q" + op: "Input" } node { - name: 'W' - op: 'Input' + name: "W" + op: "Input" } node { - name: 'X' - op: 'MatMul' - input: 'Q' - input: 'W' + name: "X" + op: "MatMul" + input: "Q" + input: "W" }`; tf.graph.parser.parseGraphPbTxt(new Blob([pbtxt])).then(nodes => { assert.isTrue(nodes != null && nodes.length === 3); + + assert.equal('Q', nodes[0].name); + assert.equal('Input', nodes[0].op); + + assert.equal('W', nodes[1].name); + assert.equal('Input', nodes[1].op); + + assert.equal('X', nodes[2].name); + assert.equal('MatMul', nodes[2].op); + assert.equal('Q', nodes[2].input[0]); + assert.equal('W', nodes[2].input[1]); + done(); }); }); test('d3 exists', () => { assert.isTrue(d3 != null); }); - // TODO(bp): write tests. + // TODO(nsthorat): write tests. }); |