aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/python
diff options
context:
space:
mode:
authorGravatar A. Unique TensorFlower <gardener@tensorflow.org>2016-06-29 16:27:35 -0800
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2016-06-29 17:32:17 -0700
commit3f488101d8d18d1bf8457ec5e2bd2c39ddea65a0 (patch)
treecc162b402f2d8f26e414ff447cbddd53b014a1b7 /tensorflow/python
parent1d92cfcbf5c157b3e4069741ae5bdbbea6666dc5 (diff)
Improve error diagnostics in embedding_lookup.
Change: 126251739
Diffstat (limited to 'tensorflow/python')
-rw-r--r--tensorflow/python/ops/embedding_ops.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/tensorflow/python/ops/embedding_ops.py b/tensorflow/python/ops/embedding_ops.py
index 06be27633b..c948eeb6ff 100644
--- a/tensorflow/python/ops/embedding_ops.py
+++ b/tensorflow/python/ops/embedding_ops.py
@@ -73,11 +73,11 @@ def embedding_lookup(params, ids, partition_strategy="mod", name=None,
Raises:
ValueError: If `params` is empty.
"""
+ if params is None or params == []: # pylint: disable=g-explicit-bool-comparison
+ raise ValueError("Need at least one param")
if not isinstance(params, list):
params = [params]
with ops.op_scope(params + [ids], name, "embedding_lookup") as name:
- if not params:
- raise ValueError("Need at least one param")
np = len(params) # Number of partitions
params = ops.convert_n_to_tensor_or_indexed_slices(params, name="params")
if np == 1: