diff options
| author |  A. Unique TensorFlower <nobody@tensorflow.org> | 2016-03-11 18:29:25 -0800 |
|---|---|---|
| committer |  TensorFlower Gardener <gardener@tensorflow.org> | 2016-03-11 20:46:08 -0800 |
| commit | 3b55e1f4f4be8fd4a6a5084edf9daf01e0990c3c (patch) | |
| tree | 16934f8a8322cd47b54bc43110337dde23c80811 /tensorflow/core/lib/strings/numbers_test.cc | |
| parent | 90b1700d0df12cd03a4bfb75743bcf60a3c90255 (diff) | |
Change safe_strto32 and safe_strto64 to accept StringPiece. Updates callers to
pass the StringPiece values.
Change: 117027762
Diffstat (limited to 'tensorflow/core/lib/strings/numbers_test.cc')
| -rw-r--r-- | tensorflow/core/lib/strings/numbers_test.cc | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tensorflow/core/lib/strings/numbers_test.cc b/tensorflow/core/lib/strings/numbers_test.cc index 67fec856a1..88acd57852 100644 --- a/tensorflow/core/lib/strings/numbers_test.cc +++ b/tensorflow/core/lib/strings/numbers_test.cc @@ -110,6 +110,13 @@ TEST(safe_strto32, Int32s) { // Overflow EXPECT_EQ(false, safe_strto32("2147483648", &result)); EXPECT_EQ(false, safe_strto32("-2147483649", &result)); + + // Check that the StringPiece's length is respected. + EXPECT_EQ(true, safe_strto32(StringPiece("123", 1), &result)); + EXPECT_EQ(1, result); + EXPECT_EQ(true, safe_strto32(StringPiece(" -123", 4), &result)); + EXPECT_EQ(-12, result); + EXPECT_EQ(false, safe_strto32(StringPiece(nullptr, 0), &result)); } TEST(safe_strto64, Int64s) { @@ -139,6 +146,13 @@ TEST(safe_strto64, Int64s) { // Overflow EXPECT_EQ(false, safe_strto64("9223372036854775808", &result)); EXPECT_EQ(false, safe_strto64("-9223372036854775809", &result)); + + // Check that the StringPiece's length is respected. + EXPECT_EQ(true, safe_strto64(StringPiece("123", 1), &result)); + EXPECT_EQ(1, result); + EXPECT_EQ(true, safe_strto64(StringPiece(" -123", 4), &result)); + EXPECT_EQ(-12, result); + EXPECT_EQ(false, safe_strto64(StringPiece(nullptr, 0), &result)); } } // namespace strings |