aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/core/kernels/sdca_internal.cc
diff options
context:
space:
mode:
authorGravatar A. Unique TensorFlower <gardener@tensorflow.org>2018-08-31 10:18:20 -0700
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2018-08-31 10:25:57 -0700
commitec7c5bf160c5216b322b65a298b1f83aae1c7d32 (patch)
tree78ee328c63119224b0a7b5b1078a31ec0c2c3018 /tensorflow/core/kernels/sdca_internal.cc
parentfd008b3905d9a3f453f1180413440dcdf41f54f3 (diff)
More robust test of the SDCA ComputeUpdatedDual method.
This exposed a sign error in the logistic loss and an error in the residual computation of the adaptive sampling algorithm. PiperOrigin-RevId: 211103287
Diffstat (limited to 'tensorflow/core/kernels/sdca_internal.cc')
-rw-r--r--tensorflow/core/kernels/sdca_internal.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/tensorflow/core/kernels/sdca_internal.cc b/tensorflow/core/kernels/sdca_internal.cc
index 1c071d3d41..a8e9b3261c 100644
--- a/tensorflow/core/kernels/sdca_internal.cc
+++ b/tensorflow/core/kernels/sdca_internal.cc
@@ -251,7 +251,7 @@ Status Examples::SampleAdaptiveProbabilities(
num_weight_vectors);
const double kappa = example_state_data(example_id, 0) +
loss_updater->PrimalLossDerivative(
- example_statistics.wx[0], label, example_weight);
+ example_statistics.wx[0], label, 1.0);
probabilities_[example_id] = example_weight *
sqrt(examples_[example_id].squared_norm_ +
regularization.symmetric_l2() *